search

gruntwork-io / terraform-google-sql

Terraform modules for deploying Google Cloud SQL (e.g. MySQL, PostgreSQL) in GCP
https://gruntwork.io
Apache License 2.0
92 stars 103 forks source link

Add backup_location option #62

Closed jsirianni closed 1 year ago

jsirianni commented 3 years ago

Resolves https://github.com/gruntwork-io/terraform-google-sql/issues/61

This PR allows the user to optionally set backup_location, which defaults to null. Existing behavior is preserved.

I did not modify the tests, but I can if given some direction.

jsirianni commented 3 years ago

@robmorgan @yorinasub17, sorry to bother you. Usually these small fixes are responded to pretty quickly, just wanted to make sure this was not missed.

Thanks 👍

jsirianni commented 2 years ago

Friendly ping on this. We have our own fork for now but I try to use upstream when possible. Any feedback would be appreciated.

Etiene commented 2 years ago

Apologies for the delay in responding to this PR. Please see below:

Sunset notice

We believe there is an opportunity to create a truly outstanding developer experience for deploying to the cloud, however developing this vision requires that we temporarily limit our focus to just one cloud. Gruntwork has hundreds of customers currently using AWS, so we have temporarily suspended our maintenance efforts on this repo. Once we have implemented and validated our vision for the developer experience on the cloud, we look forward to picking this up. In the meantime, you are welcome to use this code in accordance with the open source license, however we will not be responding to GitHub Issues or Pull Requests.

If you wish to be the maintainer for this project, we are open to considering that. Please contact us at support@gruntwork.io.

MoonMoon1919 commented 1 year ago

Closing due to repo sunset