search

gruntwork-io / terraform-google-sql

Terraform modules for deploying Google Cloud SQL (e.g. MySQL, PostgreSQL) in GCP
https://gruntwork.io
Apache License 2.0
92 stars 103 forks source link

Postgres query insights support #75

Closed ricardolpd closed 1 year ago

ricardolpd commented 2 years ago

We are currently this module for our postgres db instances, however we need to enable query insights with the posgres engine. Would it be acceptable for this repo maintainers if i made PR with changes to enable insights for postgres only?

I have made a branch on my account: https://github.com/ricardolpd/terraform-google-sql/tree/feat/enable_postgres_query_insights

affected code in main...

    dynamic "insights_config" {
      for_each = local.is_postgres == true && var.query_insights_enabled ? [1] : []
      content {
        query_insights_enabled  = var.query_insights_enabled
        query_string_length     = var.insights_query_string_length
        record_application_tags = var.insights_record_application_tags
        record_client_address   = var.insights_record_client_address
      }
    }

Question (we wont have yet the need for a read replica, can these be enabled in the replicas/failover replicas) ?

And finally, how long would it take usually to per-review it?

Etiene commented 2 years ago

Apologies for the delay in responding to this issue. Please see below:

Sunset notice

We believe there is an opportunity to create a truly outstanding developer experience for deploying to the cloud, however developing this vision requires that we temporarily limit our focus to just one cloud. Gruntwork has hundreds of customers currently using AWS, so we have temporarily suspended our maintenance efforts on this repo. Once we have implemented and validated our vision for the developer experience on the cloud, we look forward to picking this up. In the meantime, you are welcome to use this code in accordance with the open source license, however we will not be responding to GitHub Issues or Pull Requests.

If you wish to be the maintainer for this project, we are open to considering that. Please contact us at support@gruntwork.io.

eak12913 commented 1 year ago

Closing due to repo sunset