Open maunzCache opened 2 years ago
Thanks for your effort in improving our CI/CD flow!
You bring up a lot of good points. Here are a few top level comments that come to mind:
terraform-fmt
in pre-commit are actually not relevant for this repo. That said, agree that it is a good idea to keep those up to date as well. Which brings me to...Hope this makes sense! Happy to keep discussing options for better collaborating on this despite the challenges above! In the meantime, any PRs that propose version bumps in dependabot fashion (e.g., a PR that bumps versions in the docker files and gemfiles for the docs
folder) is much appreciated, and would be accepted.
Thank you for the response and fast removal of the appveyor. This got me pretty confused.
I'd like to keep this issue open until you released your fancy stuff then and see if there are still open issues to discuss or if my lists shrinks with that. If i or someone else has a nice solution for the above, feel free to pursue. And still docs are always good so i'd like to put your last words regarding bot PRs somewhere into the contribution docs.
During preparation of #2180 i noticed some issue regarding the CICD pipeline which does the testing for this project. To cut it short in this introduction i'd generally suggest to write some documentation how CICD works for this project and how to contribute to it. Additionally prepare a roadmap on how to update all CICD components that are outdated:
appveyor.yml
and.circleci/config.yml
are required. I rarely know the services but it looks to me that AppVeyor was replaced by CircleCI. Fixed in #2194docs/
that explains contribution to the CICD pipeline which does the testing and building. Initial focus would be which files have to be updated and how to upgrade runtimes such as a new Terraform or Go version..circleci/config.yml
pre-commit
pip to next major, including all dependencies. Python 3.6 is EOL so everything should be compatible with supported versionspre-commit
repository version. This project uses 0.1.10 but 0.1.17 is latest and contains relevant changes forterraform-fmt
gofmtcheck.sh
update script to reflect changes in terraform. They have removed the vendor specific lookup.docs/Dockerfile
anddocs/Gemfile