Fixing running pseudo-tty commands

levkohimins commented 3 weeks ago

Description

Fixes #3507.

The PR also fixed the error message error forwarding stdin: write /dev/ptmx: input/output error that was always displayed when exiting the console.

TODOs

Read the Gruntwork contribution guidelines.

[ ] Update the docs.
[ ] Run the relevant tests successfully, including pre-commit checks.
[ ] Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
[ ] Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Added / Removed / Updated [X].

Migration Guide

denis256 commented 3 weeks ago

Can a test be added to ensure this issue does not happen again?

levkohimins commented 3 weeks ago

Can a test be added to ensure this issue does not happen again?

I tried to add an integration test but couldn't find a way to interact with stdin through the cli package. If you have any suggestions, I'd like to consider them.

levkohimins commented 3 weeks ago

This could potentially be a separate CircleCI job to run the compiled executable in various scenarios. However, I believe that might fall outside the scope of this PR.

I created an issue #3521

levkohimins commented 2 weeks ago

Resolved in v0.68.5 release.

gruntwork-io / terragrunt