search

grunwaldlab / effectR

An R package to call oomycete effectors
10 stars 7 forks source link

Improved error handling in hmm.search #16

Closed Neato-Nick closed 5 years ago

Neato-Nick commented 5 years ago

Fixed a link in the README, addressed https://github.com/grunwaldlab/effectR/issues/15

Tabima commented 5 years ago

Awesome. I tested it and it looks great. Solves #15.

@Neato-Nick, before I merge, do you want to write a little spiel on how this function works in the readme?

Also, I like to fwd people to the HMM manual but I also like your solution. Lets keep your solution, then.

Neato-Nick commented 5 years ago

@Tabima sure, I've updated the documentation for hmm.search to reflect these changes https://github.com/grunwaldlab/effectR/pull/16/commits/17b2fc0954054c33b6b831cd6f8652c6c1374af5. In retrospect I'm not sure why I put README in that commit message... It doesn't touch the README at all. It's only changes to the help text of hmm.search.