search

grunwaldlab / poppr

🌶 An R package for genetic analysis of populations with mixed (clonal/sexual) reproduction
https://grunwaldlab.github.io/poppr
68 stars 26 forks source link

220 add bruvos between #223

Closed davefol closed 4 years ago

davefol commented 4 years ago

Closes #220

bruvo.between() exposes the same api as bruvo.dist() except for the extra required argument ref. It also returns the same object except for NaN for distances that are not a comparison between query and ref.

Internally it uses bruvo_between() which skips unneeded values and fills them with 100, later converted to NaN.

davefol commented 4 years ago

Hi Zhian, I think I handled everything in https://github.com/grunwaldlab/poppr/pull/223/commits/d862c3e3e7f9078f18cc4d5982c86290b5c77895

Let me know if I missed anything.

zkamvar commented 4 years ago

It looks good to me! The documentation needed to be re-roxygenized and NEWS updated, but I can take care of that. Thank you for the contribution!

davefol commented 4 years ago

Thanks for making it so easy. Would love to dig into the library more and contribute where needed.