update denominator for bitwise.ia to be int64_t

grunwaldlab / poppr

🌶 An R package for genetic analysis of populations with mixed (clonal/sexual) reproduction

https://grunwaldlab.github.io/poppr

68 stars 26 forks source link

update denominator for bitwise.ia to be int64_t #235

Closed zkamvar closed 3 years ago

zkamvar commented 3 years ago

Windows machines apparently do not treat long int the same way that UNIX machines do and caused integer overflows for people who were performing bitwise.ia() on sample sizes of more than 2000 loci x 200 individuals. This wasn't caught earlier because I had skipped these tests on CRAN and appveyor didn't run them either. This fixes the problem and adds a news item.

This will fix #234

zkamvar commented 3 years ago

N.B. the tests that are currently failing on windows are failing solely because of trying to match temporary paths on windows and not anything substantial

zkamvar commented 3 years ago

Mac is failing because of weird LaTeX corner case, but otherwise, it's good to go