grunwaldlab / poppr

🌶 An R package for genetic analysis of populations with mixed (clonal/sexual) reproduction
https://grunwaldlab.github.io/poppr
68 stars 26 forks source link

CRAN Errors to fix by 2023-03-22 #256

Closed zkamvar closed 1 year ago

zkamvar commented 1 year ago

Dear maintainer,

Please see the problems shown on https://cran.r-project.org/web/checks/check_results_poppr.html.

Please correct before 2023-03-22 to safely retain your package on CRAN.

Best, -k


Version: 2.9.3 Check: whether package can be installed Result: WARN Found the following significant warnings: init.c:24:21: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes] omp_test.c:7:14: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes] See ‘/home/hornik/tmp/R.check/r-devel-clang/Work/PKGS/poppr.Rcheck/00install.out’ for details.

Version: 2.9.3 Check: Rd files Result: NOTE checkRd: (-1) genetic_distance.Rd:106: Escaped LaTeX specials: \~ Flavors: r-devel-linux-x86_64-debian-clang, r-devel-linux-x86_64-debian-gcc, r-devel-linux-x86_64-fedora-clang, r-devel-linux-x86_64-fedora-gcc

Version: 2.9.3 Check: tests Result: ERROR

 Running ‘test-all.R’ [19s/23s]
Running the tests in ‘tests/test-all.R’ failed.
Complete output:
 > library(testthat)
 > options(poppr.debug = TRUE)
 > test_check("poppr")
 Loading required package: poppr
 Loading required package: adegenet
 Loading required package: ade4

 /// adegenet 2.1.10 is loaded ////////////

 > overview: '?adegenet'
 > tutorials/doc/questions: 'adegenetWeb()'
 > bug reports/feature requests: adegenetIssues()

 This is poppr version 2.9.3. To get started, type package?poppr
 OMP parallel support: available
 [ FAIL 2 | WARN 0 | SKIP 181 | PASS 378 ]

 ══ Skipped tests ═══════════════════════════════════════════════════════════════
 • On CRAN (181)

 ══ Failed tests ════════════════════════════════════════════════════════════════
 ── Failure ('test-msn.R:438'): nodes are properly scaled ───────────────────────
 sort(...) not equal to sort(...).
 Attributes: < Modes: list, NULL >
 Attributes: < Lengths: 2, 0 >
 Attributes: < names for target but not for current >
 Attributes: < current is not list-like >
 target is table, current is numeric
 Backtrace:
 ▆
 1. └─poppr (local) expect_vertex_size_scale(bmsn, as.integer(table(mll(pc)))) at test-msn.R:438:2
 2. ├─base::eval(...) at test-msn.R:105:2
 3. │ └─base::eval(...)
 4. └─testthat::expect_equal(...)
 ── Failure ('test-msn.R:439'): nodes are properly scaled ───────────────────────
 sort(...) not equal to sort(...).
 Attributes: < Modes: list, NULL >
 Attributes: < Lengths: 2, 0 >
 Attributes: < names for target but not for current >
 Attributes: < current is not list-like >
 target is table, current is numeric
 Backtrace:
 ▆
 1. └─poppr (local) expect_vertex_size_scale(pmsn, as.integer(table(mll(pc)))) at test-msn.R:439:2
 2. ├─base::eval(...) at test-msn.R:105:2
 3. │ └─base::eval(...)
 4. └─testthat::expect_equal(...)

 [ FAIL 2 | WARN 0 | SKIP 181 | PASS 378 ]
 Error: Test failures
 Execution halted
zkamvar commented 1 year ago

apparently 85209b3 did not actually do anything -_-

zkamvar commented 1 year ago

fixed by #257