gruppe-adler / Shoot_and_Scoot.Tanoa

TvT game mode - artillery vs. sound directionfinders vs. hunter-killer-teams
5 stars 1 forks source link

Crater not created where impact happened #20

Closed b-mayr-1984 closed 9 months ago

b-mayr-1984 commented 1 year ago

A strange thing happens when playing on the GRAD server (not when I host the server locally on my machine).

Where shells land and where the crater is created is just roughly in the same vicinity, but not accurate. image

This does not happen when using the Zeus module for 155mm artillery fire support (or 82mm mortar for that matter). But it happens when firing artillery yourself or let AI fire it.

b-mayr-1984 commented 1 year ago

Problem also shows in last game night's video footage.

The black impact crater textures don't show any brown dirt texture, nor do they show terrain deformation. image

Proper craters would look like this: image

b-mayr-1984 commented 1 year ago

@diwako do you have any idea what could be wrong?

As far as I understand you are simply passing the _pos you get from the Explode event.

b-mayr-1984 commented 1 year ago

Also the footage from the Proof of Concept game night shows the problem. (Given this was the first game we played I guess it is safe to assume the problem has been there from the beginning.) image

b-mayr-1984 commented 1 year ago

Here's a theory:

The craters are actually correct but the smoke and black texture land on the wrong position. When I watch the footage from the 2 game nights it becomes apparent:

Need to test the following:

b-mayr-1984 commented 1 year ago

Bullet traces (BIS_fnc_traceBullets) agree with the Vanilla splash texture, not the crater. 🤔 image D30J was used

b-mayr-1984 commented 1 year ago

Vanilla assets show the same problem. So it is not a problem of modded artillery only.

Tested with:

image

b-mayr-1984 commented 1 year ago

Some more insight:

The grass cutter seems to be properly placed. Just the crater isn't. image

b-mayr-1984 commented 1 year ago

A minimalist mission to create the problem can be found in Crater_bug.VR.zip. It only requires CBA on both server and client in order to reproduce the problem. image

Reproduction steps:

  1. take the only slot that is available
  2. use MK6 mortar via Artillery Computer and shot the opposite side of the pond
  3. observe the impact texture vs. the crater (e.g. using Zeus view)
  4. repeat step 2. and 3. if problem is not clearly shown on first try.
b-mayr-1984 commented 1 year ago

This has been reported by @dedmen as fixed from BI side.

Fix can be expected in production soon (see conversation on Discord).

b-mayr-1984 commented 11 months ago

Fix is on dev-branch by now. https://forums.bohemia.net/forums/topic/140837-development-branch-changelog/?do=findComment&comment=3477416

b-mayr-1984 commented 10 months ago

Fix should be on Stable now. https://dev.arma3.com/post/spotrep-00111

I will close this issue once successfully tested.

b-mayr-1984 commented 9 months ago

Awesome, it works! 😃 @dedmen you're the best! 👍 image

Tested using this version on both client and server.

Build: Stable
Version: 2.14.150957