search

gruppe-adler / gruppe_adler_mod

Gruppe Adler Mod is a collection of Gruppe Adler original addons that add new functionality or modify and improve existing functionality to suit our Arma gameplay.
GNU General Public License v2.0
10 stars 6 forks source link

fix #208 : bug in loadout export where WeaponUnderbarrel should be WeaponUnderbarrelMagazine #209

Closed Fusselwurm closed 1 year ago

Fusselwurm commented 1 year ago

@Fusselwurm where can I download the CI artifact in order to test it?

afaics https://github.com/gruppe-adler/gruppe_adler_mod/actions/runs/4332763655 at the bottom

b-mayr-1984 commented 1 year ago

@Fusselwurm where can I download the CI artifact in order to test it?

afaics https://github.com/gruppe-adler/gruppe_adler_mod/actions/runs/4332763655 at the bottom

@Fusselwurm just tested it and it works. 🙂

I still think though that this change regarding line 44 still should be incorporated.

I'd say that line 44 should also be changed, even though it is currently just a comment. Otherwise the code just doesn't look consistent.

Alternatively the entire comment block around line 44 could just be removed. (But I don't know if someone might still need this in the future.)