search

gruppe-adler / gruppe_adler_mod

Gruppe Adler Mod is a collection of Gruppe Adler original addons that add new functionality or modify and improve existing functionality to suit our Arma gameplay.
GNU General Public License v2.0
10 stars 6 forks source link

Dynamic Groups - Applied optimisations based HEMTT suggestions #212

Open OverlordZorn opened 1 month ago

b-mayr-1984 commented 1 week ago

@OverlordZorn man... this source file

Not fun to check the changes.

And those aren't really changing the functionality, right? They might just change runtime performance?

dedmen commented 1 week ago

Does this effort make sense, considering HEMTT's optimizer will do most of these tweaks by itself anyway?

OverlordZorn commented 1 week ago

@OverlordZorn man... this source file

* hasn't been touched in 7 years (No, `;` from @Fusselwurm doesn't count 😛)

* is ~1800 lines long 😖

Not fun to check the changes.

And those aren't really changing the functionality, right? They might just change runtime performance?

I have Dynamic Groups integrated into our unit mod. everytime i build and test something, hemtt threw these "warnings" at me at how much i can improve it.

I added these changes on my side, so hemtt shuts up.

Since i did the work already, i thought "might as well provide it to the OG repo"

OverlordZorn commented 1 week ago

i run these changes on our units mod and there have been no issues being noted on our side.