Switch terminal color codes of aqua and neutral blue

gruvbox-community / gruvbox

Retro groove color scheme for Vim - community maintained edition

MIT License

801 stars 62 forks source link

Switch terminal color codes of aqua and neutral blue #109

Closed hupfdule closed 5 years ago

hupfdule commented 5 years ago

I think you did the wrong thing in #60.

You switched aqua (#427b58) from 66 to 65, but left neutral blue (#458588) at 66.

Looking at the colors from a script that displays the terminal colors like print256colours.sh it should be the other way around. The color with code 66 has exactly the same hex value as gruvbox' aqua.

However the hex value for gruvbox' neutral blue is not that obvious. I think 24 is the one that is nearest to it and that should be the one that should be changed.

So I propose to

change terminal color code of aqua back to 66
change terminal color code of neutral bue to 24

Please see that attached image that (hopefully) shows what I mean.

colors

hupfdule commented 5 years ago

Damn! I just saw that 24 is already taken by bright blue (with exactly the same hex value). So it needs to be some other color code for neutral blue. Maybe 30?

rbong commented 5 years ago

What terminal setup are you using? In both Alacritty and rxvt I get 5f8787 for 66. That is the generally accepted color code according to this 256 color xterm reference: https://jonasjacek.github.io/colors/

You may be using a config file that sets 66 to gruvbox-light dark-aqua, in which case it needs to be updated. However if there is still a more close approximation to light blue and dark aqua I am happy to switch it.

hupfdule commented 5 years ago

That's a bit strange. See below an example where I have done this test with

kitty with this configuration
kitty with the default configuration
urxvt with solarized colors (specified via .Xdefaults)
lxterminal with the default configuration

In all cases except the solarized urxvt the hex value of 66 is 427b58.

multiple

I now did a test with a different virtual machine and tried it with urxvt, xterm, lxterminal and uxterm. And there I get a hex value of 5f8787.

That seems a bit strange to me. I would have expected that the modifications to my .Xdefaults can be a problem, but neither lxterminal nor kitty should be influenced by these modifications.

hupfdule commented 5 years ago

Since 5f8787 seems to be the correct color for code 66, I think you have done it right and I suggest you close this issue.

But it still puzzles me what is different in my system that even kitty and lxterminal get different colors…

rbong commented 5 years ago

Are you perhaps sourcing the gruvbox 256 color palette script somewhere in your shell?

hupfdule commented 5 years ago

Of course! I just forgot that and therefore was surprised of the outcome. Thank you for pointing me to that.