Adapt `LspDiagnostics*` highlight groups to latest neovim upstream changes (fixes #147)

gruvbox-community / gruvbox

Retro groove color scheme for Vim - community maintained edition

MIT License

801 stars 62 forks source link

Adapt `LspDiagnostics*` highlight groups to latest neovim upstream changes (fixes #147) #148

Closed ybc37 closed 3 years ago

ybc37 commented 3 years ago

Hey there!

I adapted the highlight groups based on:

:help lsp-highlight-diagnostics
Info in diagnostic-nvim: https://github.com/nvim-lua/diagnostic-nvim/issues/73
The commit in neovim (relevant changes)

I set LspDiagnosticsDefault* and removed virtual text and floating highlight groups, because they link to default, AFAIU. Fixes #147.

Would be great if someone could review/test :) Thanks!

rbong commented 3 years ago

Can you keep the old highlight groups for now and add the new ones, and add a comment indicating that? I'd like to not break older versions of nvim for now. Thank you!

ybc37 commented 3 years ago

Thanks for the fast feedback :)

IMHO it's not worth to keep the previous highlight groups for compatibility, because neovims built-in LSP wasn't released yet in an official version. It only concerns people following head.

But if you still prefer to keep them I'll change it, of course! (I'm just afraid I can't do it before Sunday.)

rbong commented 3 years ago

Ah okay, I didn't know that. That's fine then.