search

gruvbox-community / gruvbox

Retro groove color scheme for Vim - community maintained edition
MIT License
801 stars 62 forks source link

Let htmlScriptTag point to htmlTag. #166

Closed Kharacternyk closed 3 years ago

Kharacternyk commented 3 years ago

The current highlighting for the <script> tag is inconsistent not only with the other tags but also with the closing </script>.

screenshot

rbong commented 3 years ago

I have to assume that the highlighting for htmlScriptTag is intentional. Is there an htmlScriptEndTag or similar that can be changed instead? If no such tag exists, or if there is evidence this styling is unintentional, this can be merged in without issue.

Kharacternyk commented 3 years ago

There isn't anything like htmlScriptEndTag. htmlScriptTag is highlighted like this since b7f4337, which introduced the HTML highlighting, so I agree that it's somewhat scary to change such old stuff. If the <script> tag should stand out, could we at least make it bold, like the other tags are, but keep the purple color?

rbong commented 3 years ago

I would prefer consistency as well, so if there's no such highlight group let's merge this in.

rbong commented 3 years ago

Thanks for your contribution!