gruvbox-community / gruvbox

Retro groove color scheme for Vim - community maintained edition
MIT License
801 stars 62 forks source link

Review Language Highlight Groups #193

Closed rbong closed 11 months ago

rbong commented 11 months ago

Languages have been very inconsistent in the past.

We do have generic highlight groups, but they're not used.

TreeSitter uses more consistent colors, with different colors for brackets, variables, functions, and special characters.

We should review languages to make sure they're consistent, and potentially remove custom language groups if they're no longer required.

rbong commented 11 months ago

Pretty much all languages now use generic highlight groups like Function, Include, Operator, Special, etc.

This really shouldn't be required for a colorscheme, but what can I say? Vim syntax files are a bit of a mess. It's much better than fixing languages by linking them to different colors one-by-one, which is pretty much what we did before.

Languages should look very similar across the board whether you have TreeSitter highlight enabled or have regex highlighting on top of TreeSitter highlighting.

Sorry if anyone doesn't like the new colors, but nothing was done without reason. I hope you will like that you can switch between languages and still know what different colors mean, and that you can customize language colors globally more easily. If you have color settings that you prefer for Gruvbox that are better, please post them here or in a new issue.

This makes new screenshots a priority, see #97