search

gruvbox-community / gruvbox

Retro groove color scheme for Vim - community maintained edition
MIT License
801 stars 62 forks source link

Faded aqua (#427b58) and neutral blue (#458588) have same terminal colors #60

Closed rbong closed 5 years ago

rbong commented 5 years ago

Why is it stated that both "faded aqua" and "neutral blue" should use the 66th color of a 256-color palette? I believe that they should be distinct and the shell scripts modified so that all colors are available (both dark and light).

:robot: This issue has been automatically copied from morhetz#105 :robot:

rbong commented 5 years ago

It looks like 65 is free. And it's closer to 0x427b58 (faded aqua). We'll have to update screenshots, gruvbox-contrib, and any references to the color.

image

rbong commented 5 years ago

Updated the palette image to 65. Had to recreate the palettes in svg because there didn't appear to be a documented way to generate the palettes. Anyone should be able to modify the palette images in inkscape in the future if they have Fira Mono installed.

the new light palette

rbong commented 5 years ago

I've changed all references I can find in gruvbox and gruvbox-contrib to use 65 instead of 66 for faded aqua. I tested the color out with termguicolors off and it looked good. Contrast is even a little better with the background and blue.

You may have some issues with old references to faded aqua. I have forked a repo from gruvbox-contrib that needed updates. Please let me know if I missed any.

fish-gruvbox

Please submit an issue if you experience any troubles with the new color code. If you really, really need the old color, this workaround may work in some cases. Please still submit an issue. This will not work in tandem with the 256 color palette scripts.

let g:gruvbox_colors = { 'faded_aqua': 66 }