search

gruvbox-community / gruvbox

Retro groove color scheme for Vim - community maintained edition
MIT License
801 stars 62 forks source link

Fix the Haskell colors against haskell-vim. #87

Closed rbong closed 5 years ago

rbong commented 5 years ago

Relates to morhetz/gruvbox#190.

:robot: This pull request has been automatically copied from morhetz#209 :robot:

rbong commented 5 years ago

The original PR has a lot of positive attention and the original issue seems important. I'm going to merge this in.

mlopes commented 5 years ago

@rbong did this fix it for you? I'm still seeing it with some odd colour. Here's a screenshot of how it looks in Haskell for me vs how it looks for example when looking at the source of gruvbox:

image

image

goolord commented 3 years ago

yeah this looks pretty hideous with haskell-nvim, i don't know that many people who regularly write haskell who uses the default ftplugin

rbong commented 3 years ago

If someone wants to define some haskell-nvim highlight groups I will gladly merge it in. I'm not familiar with Haskell constructs so I'm not sure I can effectively solve this myself.

goolord commented 3 years ago

here's the highlight groups i use daily

haskell vim highlight groups (click to expand) ```vim hi! link haskelltype gruvboxyellow hi! link haskellidentifier gruvboxgreen hi! link haskellseparator gruvboxfg3 hi! link haskelldelimiter gruvboxfg3 hi! link haskelloperators gruvboxblue hi! link haskellbacktick haskelloperators hi! link haskellstatement gruvboxorange hi! link haskellconditional gruvboxred hi! link haskellkeyword gruvboxred hi! link haskelllet gruvboxred hi! link haskellwhere gruvboxred hi! link haskelldefault gruvboxaqua hi! link haskellbottom gruvboxaqua hi! link haskellblockkeywords gruvboxaqua hi! link haskellimportkeywords gruvboxaqua hi! link haskelldeclkeyword gruvboxaqua hi! link haskelldecl gruvboxaqua hi! link haskellderiving gruvboxaqua hi! link haskellassoctype gruvboxaqua hi! link haskellnumber gruvboxpurple hi! link haskellpragma gruvboxpurple hi! link haskellstring gruvboxgreen hi! link haskellchar gruvboxgreen ```

image

unfortunately, this looks nice with haskell-vim, but not great for the ftplugin that ships with vim. idk if there is precedence for supporting conflicting ftplugins like this, or if this would be better suited to being fixed upstream haskell-vim

suleymanboyar commented 3 years ago

@goolord how did you apply the changes? Sourcing vim and doing PlugUpdate doesn't seem to work.

goolord commented 3 years ago

@OnionHat I forked gruvbox, I think. I just use the default haskell ft plugin now.

suleymanboyar commented 3 years ago

@goolord thanks for the answer! Forking it and editing the part did not seem to work, oh well, but thanks again!

goolord commented 3 years ago

@OnionHat ah it looks like there are new highlight groups for the colors. (GruvboxYellow instead of gruvboxyellow etc?)