Closed gryffon closed 6 years ago
Worth noting, at the GenCon tournament, they actually had players roll to randomly determine who got to choose who went first. This was important for tiebreakers. This is a departure from the rules as written, and they will need to either release an update to the rules reference, or change the tiebreakers rules.
That's a good point. Currently, the code is just choosing a random player to go first. I think as long as we support the ability to manually pass first player, that should suffice for the purpose of releasing a beta.
Tie Breakers will be a manual step for a bit, but definitely something we can add in to help out.
I'd like to add some checks before you continue to subsequent phases. For example you can continue with 0 provinces positioned. Where should these checks be placed?
I'm not sure how useful tiebreakers are to implement at all, unless you are adding a timer as well.
@JT-Marsh setupphase.js would be the most likely place for those checks to happen.
@dodgepong People may be timing themselves. Most likely, it would just be a matter of adding a display that can show the tie-breaker points, rather than enforcing an actual tie-breaker.
@JT-Marsh For the province check you wanted, there's a prompt specifically for that called setupprovinceprompt.js. In the onMenuCommand function, it just sets a Boolean on button press that is the flag for considering the event done. I think the proper way to fix is make a function in player.js that checks all provinces are there and only sets the flag if true.
To whoever picks up this issue (I can take it if no one else wants), make sure to move the adding of the stronghold before the adding of provinces, as the placement of provinces might be affected by what clan you're going up against.
I'm not sure it's worth forcing player order onto each step. I would suggest for each of the three decision phases (Provinces, Dynasty, Conflict) the game permits players to make decisions simultaneously, but there is an announcement when each player completes the step. If players wish to follow the rules strictly, the second player simply waits for the first player's announcement before making their decisions. However, most of the time I think players will prefer to save time and not have to wait for their opponents to finish their bit before they can do their provinces/mulligans.
There's a couple of issues though that make it incorrect. Like seeing the conflict hand before doing the dynasty mulligan. This changes how a person might choose, and we want to avoid that kind of situation, where we don't have correctness because of ease.
We don't have to enforce player 1 taking their mulligan before player 2, but we should endeavor to make sure that the steps are happening in the correct order, because that's not something that a player can arbitrate manually.
I feel this has been mostly done.
While we are currently doing all of the actions required of setup, some of them are not happening int he correct order.
Posting "Setup" from the RRG for easy reference:
Setup To set up a game, perform the following steps in order:
Of note;