search

grzegorz914 / homebridge-denon-tv

Homebridge plugin for Denon/Marantz AV Receivers, publish as independent external platform accessory.
MIT License
75 stars 16 forks source link

Small improvements for Config UI X experience #140

Closed jlian closed 2 years ago

jlian commented 2 years ago

This PR contains two small changes:

  1. Add "menu" as an option for configuring the RC info button. The menu button opens up the full menu for my Denon receiver where I can configure all the options. User can click the info button on the RC to change whatever they want and use the back button to get out of it. I've validated this change myself, it works, so I think it should be added as an option for Config UI X users.
  2. Change "slider" to "lightbulb" in the volume control accessory type dropdown. This clarifies the actual type of accessory that it uses. I feel this is important in one scenario: if user tries to say "turn off all lights in the living room" they wouldn't want the volume to be muted. With the clarification they can choose "fan" as the option more directly.

Great plug-in by the way!

grzegorz914 commented 2 years ago

Thanks for the PR.