grzegorz914 / homebridge-denon-tv

Homebridge plugin for Denon/Marantz AV Receivers, publish as independent external platform accessory.
MIT License
73 stars 15 forks source link

Correct the order of inputs (issue since iOS 17) #212

Closed badgertastic closed 7 months ago

badgertastic commented 7 months ago

Hi. I think since iOS 17 (some other plugins have updated to fix the behaviour) the order of inputs is per example:

5 3 1 2 4

Can it be changed back to original:

1 2 3 4 5

Thanks.

Example of issue resolved in another plugin

badgertastic commented 7 months ago

I mean to display the inputs in the same order as configured, not just sorting them.

badgertastic commented 7 months ago

Looks to working in 4.4.0 thanks! but i did notice a few errors when changing inputs

[12/29/2023, 6:34:03 PM] [homebridge-denon-tv] Device: 10.0.20.63 Bathroom, Power: OFF
[12/29/2023, 6:34:03 PM] [homebridge-denon-tv] Device: 10.0.20.63 Bathroom, Input Name: HEOS, Reference: NET
[12/29/2023, 6:34:03 PM] [homebridge-denon-tv] Device: 10.0.20.63 Bathroom, Mute: ON
[12/29/2023, 6:34:03 PM] [homebridge-denon-tv] Device: 10.0.20.63 Bathroom, Volume: -40
[12/29/2023, 6:34:14 PM] [homebridge-denon-tv] Device: 10.0.20.63 Bathroom, Power: OFF
[12/29/2023, 6:34:25 PM] [homebridge-denon-tv] Device: 10.0.20.63 Bathroom, Input Name: BBC Radio 1, Reference: SMART1
[12/29/2023, 6:34:25 PM] [homebridge-denon-tv] Device: 10.0.20.63 Bathroom, Power: OFF
[12/29/2023, 6:34:25 PM] [homebridge-denon-tv] This plugin threw an error from the characteristic 'Active Identifier': Unhandled error thrown inside read handler for characteristic: Cannot read properties of undefined (reading 'name'). See https://homebridge.io/w/JtMGR for more info.
[12/29/2023, 6:36:47 PM] [homebridge-denon-tv] Device: 10.0.20.63 Bathroom, set Power: Z3ON
[12/29/2023, 6:36:50 PM] [homebridge-denon-tv] Device: 10.0.20.63 Bathroom, set Input Name: BBC Radio 6, Reference: SMART3
[12/29/2023, 6:36:54 PM] [homebridge-denon-tv] Device: 10.0.20.63 Bathroom, set Input Name: BBC Radio 6, Reference: SMART3
[12/29/2023, 6:36:55 PM] [homebridge-denon-tv] Device: 10.0.20.63 Bathroom, Power: ON
[12/29/2023, 6:36:55 PM] [homebridge-denon-tv] Device: 10.0.20.63 Bathroom, Input Name: BBC Radio 1, Reference: SMART1
[12/29/2023, 6:36:55 PM] [homebridge-denon-tv] This plugin threw an error from the characteristic 'Active Identifier': Unhandled error thrown inside read handler for characteristic: Cannot read properties of undefined (reading 'name'). See https://homebridge.io/w/JtMGR for more info.
[12/29/2023, 6:36:58 PM] [homebridge-denon-tv] Device: 10.0.20.63 Bathroom, set Button Name: Z3 Sleep 60m, Reference: Z3SLP060
[12/29/2023, 6:37:00 PM] [homebridge-denon-tv] Device: 10.0.20.63 Bathroom, set Input Name: BBC Radio 2, Reference: SMART2
[12/29/2023, 6:37:06 PM] [homebridge-denon-tv] Device: 10.0.20.63 Bathroom, set Input error: TypeError: Cannot read properties of undefined (reading 'name')
[12/29/2023, 6:37:12 PM] [homebridge-denon-tv] Device: 10.0.20.63 Bathroom, set Input error: TypeError: Cannot read properties of undefined (reading 'name')
grzegorz914 commented 7 months ago

Can you try 4.4.1-beta.0 and let me know

badgertastic commented 7 months ago

Still getting the Active Identifier unhandled error when switch updates status. Also noticed last input is missing from selection. Shows in home configuration screen ok but missing from actual selector dial

badgertastic commented 7 months ago

Downgraded to 4.3.x but it didn’t reinstate the missing input. Removed receiver from home and re added and have all the inputs back using 4.4.1 beta so seems there’s incompatibility between the releases.

Still have the error and also the input selector is jumping to the top again. Per. https://github.com/grzegorz914/homebridge-denon-tv/issues/181#issue-1597265154

Cheers

grzegorz914 commented 7 months ago

fixed in latest beta, try and let me know

badgertastic commented 7 months ago

Error is gone, and all inputs visible. thanks! But the selector is jumping to the top still (see https://github.com/grzegorz914/homebridge-denon-tv/issues/181#issue-1597265154 )

badgertastic commented 7 months ago

beta 25 - inputs not corresponding to the selected one beta 26 - no response from home. log: 'Device name, host, port or zone control missing!'

grzegorz914 commented 7 months ago

b.27 fixed

badgertastic commented 7 months ago

27 - inputs not corresponding to the selected one. sort none, or sort alpha.

I've rolled back to 4.3.x and will check back in a week or so. need to be stable for now.

ps. also I rolled back lg webos, as going into not responding and inputs not corresponding to selected one.

thanks

grzegorz914 commented 7 months ago

all fixed

badgertastic commented 7 months ago

4.5.0

Error, consistently appears, repeatable when navigating to Home app Home (main) screen:

[1/2/2024, 2:22:33 PM] [homebridge-denon-tv] This plugin threw an error from the characteristic 'Active Identifier': Unhandled error thrown inside read handler for characteristic: Cannot read properties of undefined (reading 'name'). See https://homebridge.io/w/JtMGR for more info.
[1/2/2024, 2:22:41 PM] [homebridge-denon-tv] This plugin threw an error from the characteristic 'Active Identifier': Unhandled error thrown inside read handler for characteristic: Cannot read properties of undefined (reading 'name'). See https://homebridge.io/w/JtMGR for more info.

Selected inputs don’t switch to correct inputs:

[1/2/2024, 2:39:42 PM] [homebridge-denon-tv] Device: 10.0.20.63 Theatre, set Input Name: Apple TV, Reference: MPLAY
[1/2/2024, 2:39:52 PM] [homebridge-denon-tv] Device: 10.0.20.63 Theatre, set Input Name: Blu-ray, Reference: TV
[1/2/2024, 2:40:13 PM] [homebridge-denon-tv] Device: 10.0.20.63 Theatre, set Input Name: HEOS Music, Reference: BD
[1/2/2024, 2:40:40 PM] [homebridge-denon-tv] Device: 10.0.20.63 Theatre, set Input Name: TV Audio, Reference: NET

Apple TV is correctly MPLAY - WORKING, OK Blu-ray should be BD - but selecting TV HEOS Music should be NET - but selecting BD TV Audio should be TV - but selecting NET

Input no longer jumping to top, fixed, thanks.

badgertastic commented 7 months ago

Anyone reading, fix for inputs not corresponding was:

rm .homebridge/denonTv/inputs*