search

grzegorzborowiak / populatefs

Tool for replacing genext2fs when creating ext4 images
GNU Lesser General Public License v2.1
5 stars 6 forks source link

Option -U owerrides uid:gid defined by device table #2

Open kosteltsev opened 8 years ago

kosteltsev commented 8 years ago

Option -U overrides uid:gid defined by device table. To fix this issue according to genext2fs behavior I suggest to change the call addFilespec() at line 125 of main.c:

from addFilespec(fd, squash_uids, squash_perms); to addFilespec(fd, 0, 0);

Please fix that issue.

oskarirauta commented 8 years ago

Thanks. Issue has been fixed in commit https://github.com/oskarirauta/populatefs/commit/e515d1f13e861f0753f0b9ada3bc703cb1ad0882

kosteltsev commented 8 years ago

Thank you!

I have found another (I hope the last issue). Please look at ticket https://dev.openwrt.org/ticket/14770 and your repository

And please make the tests. On my side I will pass some tests when I implement ext4fs image creation into my build-system (http://radix.pro).

Thans a lot for your work!

Best Regards, Andrey K.

On Tue, Oct 13, 2015 at 10:33 AM, Oskari Rauta notifications@github.com wrote:

Thanks. Issue has been fixed in commit e515d1f https://github.com/oskarirauta/populatefs/commit/e515d1f13e861f0753f0b9ada3bc703cb1ad0882

— Reply to this email directly or view it on GitHub https://github.com/oskarirauta/populatefs/issues/2#issuecomment-147630129 .