search

grzegorzborowiak / populatefs

Tool for replacing genext2fs when creating ext4 images
GNU Lesser General Public License v2.1
5 stars 6 forks source link

populatefs truncate existed regular files #3

Open kosteltsev opened 8 years ago

kosteltsev commented 8 years ago

Expected behaviour:

If file exists in the source directory (option -d) and in the device table the new owner and permissions are set. Then populatefs only changed uid,gid and permissions!!

Real bbehaviour:

Populatesf truncate exist file if new owner. permissions are described in the device table!

To fix this issue according to expected behaviour (wich we have in the genext2fs) I suggest the patch "populatefs-1.0-notrunc-rfiles.patch". The patch is attached to the ticket #14770 [https://dev.openwrt.org/ticket/14770].

Best Regards, Andrey K.

oskarirauta commented 8 years ago

Thanks again. Patch applied in commit: https://github.com/oskarirauta/populatefs/commit/95cc98bb438b64a1c0256d3735db9a1647f48ef0

kosteltsev commented 8 years ago

Thank for your work.

I have tested populatefs with these patches. It works properly. I think this is very helpful utility and populatefs will be used by a lot of people. (Probably it would be nice to create autoconfigured source code and release GNU style tarball for all embedded comunity).

Thank you. Best Regards, Andrey K.

On Tue, Oct 13, 2015 at 4:32 PM, Oskari Rauta notifications@github.com wrote:

Thanks again. Patch applied in commit: 95cc98b https://github.com/oskarirauta/populatefs/commit/95cc98bb438b64a1c0256d3735db9a1647f48ef0

— Reply to this email directly or view it on GitHub https://github.com/oskarirauta/populatefs/issues/3#issuecomment-147715192 .