Proprietary Software keeping Chanu out of F-Droid

[yate]

I saw this topic at f-droid https://f-droid.org/forums/topic/chanu-4chan-app/.

I'm guessing libGoogleAnalyticsV2.jar is the propriety jar? Is removing this an option? Is getting the app on f-droid a goal for you guys?

[johnarleyburns]

yes a goal it should be easily removable only one class does the analytics On Oct 8, 2014 10:17 PM, "yate" notifications@github.com wrote:

I saw this topic at f-droid https://f-droid.org/forums/topic/chanu-4chan-app/.

I'm guessing libGoogleAnalyticsV2.jar is the propriety jar? Is removing this an option? Is getting the app on f-droid a goal for you guys?

— Reply to this email directly or view it on GitHub https://github.com/grzegorznittner/chanu/issues/421.

[yate]

This means getting rid of billing/purchasing of pro keys?

[johnarleyburns]

yes On Oct 9, 2014 8:03 PM, "yate" notifications@github.com wrote:

This means getting rid of billing/purchasing of pro keys?

— Reply to this email directly or view it on GitHub https://github.com/grzegorznittner/chanu/issues/421#issuecomment-58600286 .

[yate]

https://f-droid.org/forums/topic/chanu-4chan-app/#post-12742

[johnarleyburns]

Thanks!

On Fri, Oct 10, 2014 at 10:50 AM, yate notifications@github.com wrote:

https://f-droid.org/forums/topic/chanu-4chan-app/#post-12742

— Reply to this email directly or view it on GitHub https://github.com/grzegorznittner/chanu/issues/421#issuecomment-58674978 .

[ghost]

Where did nineoldandroids-2.4.0.jar come from? It doesn't match the signature of the upstream package from https://github.com/JakeWharton/NineOldAndroids/downloads and replacing it with a version build from the latest upstream sources throws missing resource errors...

[yate]

@krt16s I've submitted a pull request with the official jar. I think the missing resource errors were because the project needs to be built on the ui-experimental branch currently. Were you building on master?

[johnarleyburns]

Please re-pull, we've merged in the upstream version and it passes travis ci on the ui-experimental branch. On Oct 17, 2014 7:46 PM, "Boris Kraut" notifications@github.com wrote:

Where did nineoldandroids-2.4.0.jar come from? It doesn't match the signature of the upstream package from https://github.com/JakeWharton/NineOldAndroids/downloads and replacing it with a version build from the latest upstream sources throws missing resource errors...

— Reply to this email directly or view it on GitHub https://github.com/grzegorznittner/chanu/issues/421#issuecomment-59592988 .

[ghost]

Should be build tonight.

[yate]

https://f-droid.org/repository/browse/?fdfilter=chanu&fdid=com.chanapps.four.activity

Awesome! Thanks @krt16s

[johnarleyburns]

Noticed a bug, I should remove the BILLING permission from the APK manifest file, also I think the android version number should be updated to avoid conflicts.

On Wed, Oct 22, 2014 at 8:26 AM, yate notifications@github.com wrote:

https://f-droid.org/repository/browse/?fdfilter=chanu&fdid=com.chanapps.four.activity

Awesome! Thanks @krt16s https://github.com/krt16s

— Reply to this email directly or view it on GitHub https://github.com/grzegorznittner/chanu/issues/421#issuecomment-60083864 .

[yate]

I have the billing permission removed from the memory-leaks pull request, i probably should have done a new one for that.

[ghost]

We try not to pull already deployed, working builds, so a version bump would be appreciated.

[johnarleyburns]

Yes, we need to version bump any time we do a charge, also in the android manifest, I'm not sure if there's a way to automate it.

On Thu, Oct 23, 2014 at 2:40 PM, Boris Kraut notifications@github.com wrote:

We try not to pull already deployed, working builds, so a version bump would be appreciated.

— Reply to this email directly or view it on GitHub https://github.com/grzegorznittner/chanu/issues/421#issuecomment-60296852 .

[yate]

Maybe a script like ./chanu-release.sh 2.0.4 which would change the numbers/date in version.xml (increment the code, name = 2.0.4, todays date), commit it, create a tag (2.0.4), then push the tag to the repo, which would trigger a travis deploy?

[johnarleyburns]

We also need to update the AndroidManifest.xml at the same time. Now it's version 1.78, but we could make it 2.0.4 to keep in sync. Also there is a section in the About screen which should also be synced, so the user knows what version they have.

On Thu, Oct 23, 2014 at 3:25 PM, yate notifications@github.com wrote:

Maybe a script like ./chanu-release.sh 2.0.4 which would change the numbers/date in version.xml (increment the code, name = 2.0.4, todays date), commit it, create a tag (2.0.4), then push the tag to the repo, which would trigger a travis deploy?

— Reply to this email directly or view it on GitHub https://github.com/grzegorznittner/chanu/issues/421#issuecomment-60303204 .

[yate]

It looks like both the manifest and the about screen use @string/versionName from version.xml. The manifest is using it's own version code though so we can probably change it to @string/versionCode, then it's all in one place.

[johnarleyburns]

Unfortunately the manifest won't interpolate the @string values, so it has to be duplicated in both places.

On Thu, Oct 23, 2014 at 3:43 PM, yate notifications@github.com wrote:

It looks like both the manifest and the about screen use @string/versionName from version.xml. The manifest is using it's own version code though so we can probably change it to @string/versionCode, then it's all in one place.

— Reply to this email directly or view it on GitHub https://github.com/grzegorznittner/chanu/issues/421#issuecomment-60305878 .