search

grzegorznittner / chanu

Chanu - 4chan for Android
https://play.google.com/store/apps/details?id=com.chanapps.four.activity
GNU General Public License v3.0
74 stars 32 forks source link

BUG: Download Thread Images Stall #430

Closed Tasuba closed 9 years ago

Tasuba commented 9 years ago

Thread image downloading notifications and process are stalled and stopped sometimes. Exact cause is unknown and causes any queued image downloads to never start.

Datastreamx commented 9 years ago

Problem still persist at 2.0.12

johnarleyburns commented 9 years ago

sorry can't reproduce On Feb 17, 2015 5:48 PM, "Datastreamx" notifications@github.com wrote:

Problem still persist at 2.0.12

— Reply to this email directly or view it on GitHub https://github.com/grzegorznittner/chanu/issues/430#issuecomment-74781191 .

Datastreamx commented 9 years ago

It usually happens on threads that I've been watching for a long time and have been pulling from a lot. (at least a week)

Junohea commented 9 years ago

A bit more testing is required but I find it typically happens if I try to use it in a thread where an image has been removed by a mod/janitor

Datastreamx commented 9 years ago

I found this out too like 2 weeks ago. Just neglected to mention it because I'd remember it when I'd use the app and that is right before bed. But that is indeed the cause.

johnarleyburns commented 9 years ago

Uh, if the thread has been removed, the images are toast and can't be downloaded anymore, unfortunately.

On Thu, Jun 25, 2015 at 1:20 PM, Datastreamx notifications@github.com wrote:

I found this out too like 2 weeks ago. Just neglected to mention it because I'd remember it when I'd use the app and that is right before bed. But that is indeed the cause.

— Reply to this email directly or view it on GitHub https://github.com/grzegorznittner/chanu/issues/430#issuecomment-115352976 .

Junohea commented 9 years ago

Ah let me clarify, the issue that I've seen is that if an image has been removed in this manner (but the thread is still otherwise available) chanu will stall when using the "download images" function because it'll try to download a file that isn't there, and rather than continuing down the thread it comes to a stop. I've not yet looked at the code otherwise I could try to pinpoint the spot where it occurs

johnarleyburns commented 9 years ago

We will have a fix out shortly.

On Thu, Jun 25, 2015 at 7:11 PM, Junohea notifications@github.com wrote:

Ah let me clarify, the issue that I've seen is that if an image has been removed in this manner (but the thread is still otherwise available) chanu will stall when using the "download images" function because it'll try to download a file that isn't there, and rather than continuing down the thread it comes to a stop. I've not yet looked at the code otherwise I could try to pinpoint the spot where it occurs

— Reply to this email directly or view it on GitHub https://github.com/grzegorznittner/chanu/issues/430#issuecomment-115435484 .