search

grzm / awyeah-api

Cognitect's aws-api for babashka
Apache License 2.0
90 stars 3 forks source link

Fix reflection warnings in http-client #1

Closed cap10morgan closed 2 years ago

cap10morgan commented 2 years ago

I was seeing some reflection warnings in here but these changes eliminated them. The code is not as nice, but I've never figured out how to type hint the threaded arg in -> / cond-> style macros (as-> works great for this but there is no cond-as->).

borkdude commented 2 years ago

@grzm Fixing reflection issues is important for GraalVM native-image

borkdude commented 2 years ago

Perhaps it's useful to enable *warn-on-reflection* in interop-heavy namespaces to detect future problems.

cap10morgan commented 2 years ago

@grzm Can I do anything else to get this ready to merge?

grzm commented 2 years ago

Thanks for the PR. I ended up resolving this in a bit differently here: https://github.com/grzm/awyeah-api/commit/8727a206c2a2252edf78defaf9e72eaed52663d4

Let me know if you see any issues.

Cheers!