search

gs-gs / staruml-model-interchange

4 stars 1 forks source link

Type check for the properties #12

Open kshychko opened 4 years ago

kshychko commented 4 years ago

By mistake I generated my project in interchange format with "description":false instead of "description": "" properties. That didn't cause the project generation failure, but Relationships model wasn't working. We need to add a type check for the properties which are translated from interchange to starUML to avoid unexpected behavior as above. Probably the best option would be to develop a json schema for the interchange format, so other tools can use it in order to test their output in interchange format.

This is a good to have option. Development and scope needs to be approved. @onthebreeze , please provide your comment.

kshychko commented 4 years ago

icf-samples.zip The zip with the samples to reproduce the issue.

faizanvahevaria commented 4 years ago

@kshychko

By mistake I generated my project in interchange format with "description":false instead of "description": "" properties. That didn't cause the project generation failure, but Relationships model wasn't working.

Above behaviour is handled. I have query that before steven replay can you please give me simple example how interchange format will look after it is converted in json schema?

kshychko commented 4 years ago

@faizanvahevaria , something like one of the examples here - https://json-schema.org/learn/miscellaneous-examples.html

faizanvahevaria commented 4 years ago

@kshychko I handled

"description": ""

and updated the code. I start working on git untill @onthebreeze replay to convert interchange format in json-schema.

faizanvahevaria commented 4 years ago

latest code is updated in version 0.1.5

kshychko commented 4 years ago

@onthebreeze approved the schema development for the interchange format.