search

gs-shop / vue-slick-carousel

🚥Vue Slick Carousel with True SSR Written for ⚡Faster Luxstay
https://gs-shop.github.io/vue-slick-carousel/
Other
810 stars 184 forks source link

Fix - Disabled autoplay still fires events `beforeChange` #210

Open Kapcash opened 3 years ago

Kapcash commented 3 years ago

I figured out my carousel was sending a lot of beforeChange events even though nothing seemingly changed.

I found out the condition to trigger the autoplay was wrong and so it always triggers the autoplay timer whatever the props are.

To avoid any more confusion, I renamed the autoPlay method to runAutoPlay, so we're sure the names are more distincts than just a capital letter!

Kapcash commented 2 years ago

@kyuwoo-choi Sorry to bother, but can we merge this? Or at least get a review? 🙏 It's been 8 months and I'm using my fork in production lol

francisashley commented 1 year ago

Hi @kyuwoo-choi this bug is also breaking the initialSlide option,

could we please get this merged.