search

gs-shop / vue-slick-carousel

🚥Vue Slick Carousel with True SSR Written for ⚡Faster Luxstay
https://gs-shop.github.io/vue-slick-carousel/
Other
801 stars 186 forks source link

Autoplay is permanently on #260

Open francisashley opened 1 year ago

francisashley commented 1 year ago

https://github.com/gs-shop/vue-slick-carousel/blob/2e8d7313b97ff6b86427694181c9e8a4bd7b27ff/src/InnerSlider.vue#L91

This expression is checking if the internal autoPlay method exists (always truthy) when it should be checking this.autoplay.

This line of code is making the package fundamentally unstable.

@kyuwoo-choi PR https://github.com/gs-shop/vue-slick-carousel/pull/210 was created for this a year ago,

could we please get this merged.