search

gs1 / EPCIS

Draft files being shared for EPCIS 2.0 development
Other
22 stars 7 forks source link

Change in description for POST /capture endpoint required #173

Closed shalikasingh closed 3 years ago

shalikasingh commented 3 years ago

Hi @domguinard,@joelvogt, @mgh128,

This issue will only hold true if the answer to the below question is yes.

Question: Is POST /capture endpoint is also meant to capture EPCISMasterDataDocument and not alone EPCISDocument?

Adhering to the answer as yes, We believe the description of POST /capture endpoint, GS1-Capture-Error-Behaviour, and other relative areas requires an update considering master data equally valid candidate for capture endpoint as is EPCIS events.

Would like to bring into notice a small typo in openapi.yaml at Line no. 4028 as-is: If the GS1-Capture-Error-Behaviour header is rollback, success being false aboards the capture job to-be: If the GS1-Capture-Error-Behaviour header is rollback, success being false aborts the capture job

One more question just for sake of curiosity: Should we have an additional endpoint that is just responsible for capturing master data?

joelvogt commented 3 years ago

Hi @shalikasingh, it was a group decision not to include adding master data in EPCIS 2.0

CraigRe commented 3 years ago

(EPCIS 1.x already offered no means of capturing EPCIS Master Data Documents.)

CraigRe commented 3 years ago

@joelvogt please change aboard to abort. :-)

CraigRe commented 3 years ago

Consensus of 16 Feb telco agrees to remove provisions for EPCISMasterDataDocument from EPCIS 2.0, given that (in the absence of a capture interface / endpoint) it has never been deployed. (EPCIS Header will continue to support inclusion of master data.) Will double check to verify that MasterDataQuery only applied to MasterDataDocument, and could not be used for retrieval of MD from the EPCIS header.