gs1 / EPCIS

Draft files being shared for EPCIS 2.0 development
Other
20 stars 7 forks source link

`xsd:anyURI` vs URI #206

Closed VladimirAlexiev closed 3 years ago

VladimirAlexiev commented 3 years ago

The SHACL shape and https://ns.mh1.eu/epcis/ show xsd:anyURI as range for several properties. However, xsd:anyURI is a literal not a URI.

Instead, these props:

VladimirAlexiev commented 3 years ago

This script makes the prop list below.

riot -out nt EPCIS.ttl | perl -ne 'print if s{.*epcis/(.*?)>.*rangeIncludes.*anyURI.*}{1. $1}'

I've added suggested ranges, conforming to EPCIS fields to classes; added a few at the bottom

  1. bizRules: ?
  2. bizStep: cbv:BizStep
  3. bizTransaction: epcis:BizTransaction or epcis:BizTransactionDocument (#215)
  4. chemicalSubstance: ?
  5. childEPCs: gs1:PhysicalObject
  6. correctiveEventIDs: epcis:EPCISEvent
  7. dataProcessingMethod: ?
  8. destination: epcis:SourceOrDestination
  9. deviceID: gs1:SensorDevice ?
  10. deviceMetadata: ?
  11. disposition: cbv:Disp
  12. epcList: gs1:PhysicalObject
  13. id: none, pseudo-prop
  14. inputEPCList: gs1:PhysicalObject
  15. microorganism: ?
  16. outputEPCList: gs1:PhysicalObject
  17. parentID: gs1:PhysicalObject, gs1:Place ?
  18. rawData: ?
  19. set: cbv:Disp
  20. source: epcis:SourceOrDestination
  21. unset: cbv:Disp
  22. uriValue: ?. additions are below this line
  23. epcClass: gs1:Product
  24. quantity: xsd:double
  25. eventList: epcis:EPCISEvent
  26. epcis:correctiveEventIDs: epcis:EPCISEvent
  27. epcis:errorDeclaration epcis:ErrorDeclaration
  28. epcis:reason: cbv:ER
  29. epcis:measurementType: gs1:MeasurementType
  30. epcis:bizTransactionType: cbv:BTT,
  31. epcis:sourceOrDestinationType: cbv:SDT

For "?" we have a choice:

The CBV classes should be considered "extensible", i.e. a user is able to add a new class member (they are anyway, but we should mention it in the section "EPCIS semantics")

@mgh128 please comment by item

VladimirAlexiev commented 3 years ago

@mgh128 @CraigRe @RalphTro Can we make a decision on this one? We're ready to start implementing it (@nikolatulechki, or @nicksinch)

CraigRe commented 3 years ago

@VladimirAlexiev what are you ready to start implementing? None of this has been released to public community review yet, let alone published as a standard...

VladimirAlexiev commented 3 years ago

@CraigRe Implement changes to the ontology.

VladimirAlexiev commented 3 years ago

ontology-prop-checks.rq makes about 10 checks on props:

Only the last one has problems, they are down from 31 to 20:

epcis:bizRules epcis:bizStep epcis:bizTransaction epcis:chemicalSubstance epcis:childEPCs epcis:correctiveEventIDs epcis:dataProcessingMethod epcis:deviceID epcis:deviceMetadata epcis:disposition epcis:epcList epcis:id epcis:inputEPCList epcis:microorganism epcis:outputEPCList epcis:parentID epcis:rawData epcis:set epcis:unset epcis:uriValue

VladimirAlexiev commented 3 years ago

21fe79d (#270) fixes this. @mgh128 please: