use schema:domain/rangeIncludes in addition to owl:union; fix `epcis:type` range

VladimirAlexiev commented 3 years ago

The EPCIS ontology uses 18 owl:union to designate prop domains/ranges, eg:

epcis:type  a             owl:DatatypeProperty , rdf:Property ;
        rdfs:domain       [a owl:Class ;
                           owl:unionOf (epcis:Source epcis:Destination epcis:BizTransaction)] ;
        rdfs:range        xsd:anyURI .

This works, but I also propose to use schema:domainIncludes, which simply uses multiple values instead of OWL constructs. All of schema.org is built on it, and you can see our SWJ paper http://www.semantic-web-journal.net/content/eubusinessgraph-ontology-lightweight-ontology-harmonizing-basic-company-information-0 for some explanations of the benefits of this lighter-weight lower-ontological-commitment approach.

As argued in #206, xsd:anyURI is a wrong range, and type is not an owl:DatatypeProperty since it uses CBV lookup values. So I propose to fix it thus:

epcis:type  a             owl:ObjectProperty , rdf:Property ;
    rdfs:domain           [a owl:Class ;
                           owl:unionOf (epcis:Source epcis:Destination epcis:BizTransaction)] ;
    rdfs:range            [a owl:Class ;
                           owl:unionOf (cbv:SDT cbv:BTT)];
    schema:domainIncludes epcis:Source, epcis:Destination, epcis:BizTransaction ;
    schema:rangeIncludes  cbv:SDT, cbv:BTT.

mgh128 commented 3 years ago

That looks OK - and I'm aware of schema:domainIncludes and schema:rangeIncludes It's a pity that RDFS was never updated to include those within RDFS but it certainly avoids the owl:unionOf ugliness.

Just a polite suggestion to you, since you've been more prolific in raising issues and providing detailed technical feedback over the last two weeks than most of our work group members over the last two years:

Can you / we tag these issues ahead of next Tuesday's call so that we can prioritise discussion?

I'd suggest adding tags such as:

ontology-browser for anything like this that is completely internal to the ontology-browser tool and for which the work group haven't really considered the implementation details of the Linked Data ontology for EPCIS/CBV behind the online tool they've seen so far. Also anything relating to markdown improvements.
broken for anything that is considered fundamentally broken, flawed, dysfunctional or embarrassing
improvement for improvements to definitions etc.

Some members of the group are very keen to start community review as soon as possible. Other members are aware that various known corrections need to be made first, to avoid wasting everyone's time with issues that should have been fixed before community review or public review.

We work through the issue list on each weekly call and we'll definitely give priority to anything that is tagged as urgent or broken, even if that means deferring some of the improvements to definitions or the browser tool.

VladimirAlexiev commented 3 years ago

@mgh128, @CraigRe I'd be glad to but don't think I have rights in this repo.

Also, I haven't used Github tags, but I think I can manage (can you give me a help link?)

Or do you want to have a 1-on-1 (or 1-on-2) telco on Monday? I'm GMT+2 (latest available 9am-8pm) and prefer Google Meet.

Then we can rehash and group the issues for better overview; I'm getting lost myself ;-)
And maybe even make a 2-3 slide presentation to express ourselves better
I'll need a bit of orientation on the use of the GS1 sharepoint, work processes, etc

mgh128 commented 3 years ago

I'll need to test adding some tags / labels - the instructions are here: https://docs.github.com/en/github/managing-your-work-on-github/managing-labels

I'd assumed that the submitter of an issue or pull request is allowed to add their own tags/labels but maybe it's only repository owners.

This is one of the first GS1 work groups to use GitHub during development, so GS1 staff are owners/admins but we do consider pull requests and issues submitted by members of the work group and review these on calls, then we take care of merging in the pull requests or making the updates.

We're checking with Eddy that he's received your signed documents - and assuming that he confirms this, then a 2-way or 3-way call would be good.

I'm in Cambridge, UK, so on Monday I'll be on London time, which by then will be GMT+1 because of summertime. Google Meet is fine.

Monday is somewhat tricky for me because I'm taking a train to Newcastle so I'll be travelling most of the afternoon and likely to have intermittent connectivity on the train.

I'm not sure of Craig's availability on Monday, but he can talk you through the work processes. At this stage, we're mostly using GitHub to share code for examples, interfaces, schema and to manage the issue list. Craig is the main coordinating editor for EPCIS and CBV, although Ralph, Joël and I have contributed out chapters on sensor data, Open API REST interface and JSON/JSON-LD respectively. The documents are just far too large to edit collaboratively in a stable manner via Office 365 or Sharepoint. Eddy will set up an account for you in our community room at https://xchange.gs1.org . Each work group uses this to share its documents within the work group. There's also a group mailing list.

Provided I have everything packed this weekend, I can probably fit in a call at 0930 British summer time on Monday morning but will need to drop off by 1030 at the latest. Alternatively, my next slot with reliable connectivity probably isn't until 1730 British summer time on Monday. I have availability tomorrow mid-afternoon if that's easier.

CraigRe commented 3 years ago

@VladimirAlexiev and @mgh128 I can also join a call in the 09:30 -10:30 BST / 11:30-12:30 EEST window on Monday. Today (Friday), I can join a call at any point this afternoon, needing to drop off by 16:00 GMT / 18:00 EET.

VladimirAlexiev commented 3 years ago

@mgh128 @CraigRe

I see https://github.com/gs1/EPCIS/labels but can't change them, and on https://github.com/gs1/EPCIS/issues don't have checkboxes to apply them. I think you need to make me "contributor" to this repo, and/or add me to the GS1 github org?
I have an xchange account and sent request to join the EPCIS-CBV workgroup (As well as the Digital Links workgroup)
let's have a call right now, I'll be at http://meet.google.com/age-vyvp-web for the next 1.5h

VladimirAlexiev commented 3 years ago

@mgh128 @CraigRe I have access to https://xchange.gs1.org/cr/gsmp/mswg/gsmpepciscbvmswg/Pages/Home-wg.aspx but now am at a loss what to read :-)

mgh128 commented 3 years ago

https://xchange.gs1.org/cr/gsmp/mswg/gsmpepciscbvmswg/_layouts/15/download.aspx?SourceUrl=https://xchange.gs1.org/cr/gsmp/mswg/gsmpepciscbvmswg/Documents/2021_03_23b%20EPCIS%202-0%20COMMREV.docx&FldUrl=

and

https://xchange.gs1.org/cr/gsmp/mswg/gsmpepciscbvmswg/_layouts/15/download.aspx?SourceUrl=https://xchange.gs1.org/cr/gsmp/mswg/gsmpepciscbvmswg/Documents/2021_03_29q%20CBV%202-0%20COMMREV.docx&FldUrl=

are the current drafts for EPCIS and CBV.

Look at those clean URLs in our community room folder! 😉

VladimirAlexiev commented 3 years ago

Aye, I got these:

2021_03_08b GS1-White-Paper-On-demand-master-data.docx
2021_03_16 EPCIS Minutes.docx
2021_03_23b EPCIS 2-0 COMMREV.docx
2021_03_16c EPCIS 2.0 MasterData.pptx
2021_03_29q CBV 2-0 COMMREV.docx
2021_03_30 EPCIS Agenda.pptx
2021_03_29d EPCIS critical to-do list.xlsx

VladimirAlexiev commented 3 years ago

@CraigRe close this, it's fixed. (type is now split into 3 props)

gs1 / EPCIS

use schema:domain/rangeIncludes in addition to owl:union; fix `epcis:type` range #222