search

gs1 / EPCIS

Draft files being shared for EPCIS 2.0 development
Other
22 stars 7 forks source link

allow booleanValue for `chemicalSubstance` or `microorganism` #249

Closed VladimirAlexiev closed 3 years ago

VladimirAlexiev commented 3 years ago

booleanValue currently says "(Optional) Similar to stringValue, for Boolean value".

I propose to add "If a chemicalSubstance or microorganism field is included, booleanValue=true means that this chemical substance/microorganism is present (and then value can be used to specify the concentration), whereas booleanValue=false means that this chemical substance/microorganism is absent (and then value should not be included)".

Rationale: some sensors/tests may just detect an organism, without measuring its concentration

mgh128 commented 3 years ago

I almost agree, if you change the second clause to:

, whereas booleanValue=false means that this chemical substance/microorganism is absent ...

VladimirAlexiev commented 3 years ago

Corrected.

But now I'm wondering about "(and then value should not be included)". How about trace quantities? Eg COVID tests come negative if some measure (antigen?) is below a threshold, not necessarily flat zero.

RalphTro commented 3 years ago

Thanks, @VladimirAlexiev and @mgh128!

No objection to add this revised phrasing (with Marks tweak)

As to @VladimirAlexiev's last comment: a technical standard does not need to explain specific areas of application. This is typically agreed upon in a (GS1) implementation guideline. So, if a healthcare industry group sees a need to specify how EPCIS is leveraged in such a specific area of application, it could e.g. elaborate on trace quantities.

VladimirAlexiev commented 3 years ago

ok, so my final proposal is:

"If a chemicalSubstance or microorganism field is included, booleanValue=true means that this chemical substance/microorganism is present (and then value can be used to specify the concentration), whereas booleanValue=false means that this chemical substance/microorganism is absent"

mgh128 commented 3 years ago

... except that booleanValue does not need to be asserted just in order to assert a concentration using value.

So re-word as:

"If a chemicalSubstance or microorganism field is included, booleanValue=true means that this chemical substance/microorganism is present, while booleanValue=false means that this chemical substance/microorganism is absent, whereas value can be used to specify the concentration; a non-zero concentration value is incompatible with booleanValue=false .

Does the group agree, especially to the last clause regarding incompatibility? or should we omit that here?

RalphTro commented 3 years ago

As for me, I think the latter refinement makes sense. If true, value CAN be present, if false, NOT.

mgh128 commented 3 years ago

@RalphTro - thanks. I tried not to phrase it in a way that implies that booleanValue must be stated at all, in order to be allowed to specify a value for value, whereas the previous formulation (especially the use of 'and then') from @VladimirAlexiev could have been misunderstood that way.

I hope you would agree that it is also acceptable to specify a value for value to indicate concentration of the identified chemicalSubstance or microorganism even if no value for booleanValue is specified.

RalphTro commented 3 years ago

Dear @mgh128 - yes, of course. That, from my perspective, is the default use anyway. Thanks for the clarification.

CraigRe commented 3 years ago

Revised booleanValue description in EPCIS § 7.3.7.1.2. (Sensor Report) to reflect text suggested by @mgh128 .