gs1 / EPCIS

Draft files being shared for EPCIS 2.0 development
Other
20 stars 7 forks source link

#1 JSON Schema - a typo at line 1154 fixed: from format to type #2 JSON example - suggest the fix of Example_9.8.1 #3 XML Schema - Unique Particle Attribution violation , #4 XML Examples - event hash id, full fields #319

Closed JaewookByun closed 3 years ago

JaewookByun commented 3 years ago

During catching up on the latest JSON schema, I found a typo at line 1154.

JaewookByun commented 3 years ago

We are applying the latest JSON schema and test the provided examples one by one. During the test, we found JSON/Example_9.8.1 is not compatible with JSON Schema. It is because a property type should be provided in "vocabulary" as described like "vocabulary": { "type": "object", "properties": { "type": { "$ref": "#/definitions/uri" }, ... We suggest Example_9.8.1-MasterData-complying-with-schema-fixed.jsonld this example also contains 'cbvmda' namespace in @context.

The document is tested in our prototype, Oliot EPCIS X. (http://203.250.148.67/epcis/home/index.html) For your information, we use https://github.com/eclipse-vertx/vertx-json-schema for the schema validation

JaewookByun commented 3 years ago

3 During applying the updated XML schema at Jun23 to Oliot EPCIS X platform, we found Unique particle attribution violation in the schema yielded by allowing optional sbdh. We suggest one way to resolve it.

4 We share two groups of EPCIS Documents in XML format. (1) Some documents in both XML and JSON format

are semantical identical and produce an identical event ID. (2) The other documents in XML format use all the fields as much as possible.

jmcanterafonseca-iota commented 3 years ago

@JaewookByun the JSON Schema fixes are being addressed at #298 . I would recommend only to include the XML part in this PR and I will take care of including the JSON Schema fixes under the other PR.

JaewookByun commented 3 years ago

As @jmcanterafonseca-iota (thank you) mentioned that this issue has been already handled, I would close this request and then do pull-request in another thread.