search

gs1 / EPCIS

Draft files being shared for EPCIS 2.0 development
Other
20 stars 7 forks source link

update Ontology/CBV.ttl #343

Closed VladimirAlexiev closed 2 years ago

VladimirAlexiev commented 2 years ago

hi @mgh128, I saw you added BTT-upevt to context: https://github.com/gs1/EPCIS/search?q=btt-upevt. However, it's missing from Ontology/CBV.ttl, and as this hasn't been updated for a while, I'm sure there are other omissions too (eg cbv:Comp is completely missing).

Please update and don't forget to run make to make CBV.jsonld (you need 3 tools installed, as described in README). Cheers!

cc @CraigRe

VladimirAlexiev commented 2 years ago

https://github.com/gs1/EPCIS/commit/ef140173ed051149f20e0e4f87ed6115d6a28af0 does this for some values

mgh128 commented 2 years ago

Yes - I need to make corresponding updates in the Ontology files - I have a TO-DO list that I'm steadily working through. I will also try to run make - had installed the tools as described in the README file. Will try this again after I have made the updates.

mgh128 commented 2 years ago

Agreed - Ontology files in both formats need to be updated to align with recent additions in CBV draft, including cert, testprd, testres, upevt. Now submitting as a review comment

VladimirAlexiev commented 2 years ago

Now CBV.ttl defines the same 13 BTT values as context:

cbv:BTT-bol
cbv:BTT-cert
cbv:BTT-desadv
cbv:BTT-inv
cbv:BTT-pedigree
cbv:BTT-po
cbv:BTT-poc
cbv:BTT-prodorder
cbv:BTT-recadv
cbv:BTT-rma
cbv:BTT-testprd
cbv:BTT-testres
cbv:BTT-upevt
mgh128 commented 2 years ago

Sorry @VladimirAlexiev - I don't understand your previous comment. I just checked CBV.ttl and each of these 13 cbv:BTT values has a distinct definition etc. - so what is the problem you're intending to highlight?

VladimirAlexiev commented 2 years ago

No problem: I said "same" and closed. Closing again.