gs1 / EPCIS

Draft files being shared for EPCIS 2.0 development
Other
20 stars 7 forks source link

cbv-Comp values: casing and `geocoordinate` #345

Open VladimirAlexiev opened 2 years ago

VladimirAlexiev commented 2 years ago

component field in newest context has this enumeration:

                "x": "cbv:Comp-x",
                "y": "cbv:Comp-y",
                "z": "cbv:Comp-z",
                "axial_distance": "cbv:Comp-axial_distance",
                "azimuth": "cbv:Comp-azimuth",
                "height": "cbv:Comp-height",
                "spherical_radius": "cbv:Comp-spherical_radius",
                "polar_angle": "cbv:Comp-polar_angle",
                "elevation_angle": "cbv:Comp-elevation_angle",
                "easting": "cbv:Comp-easting",
                "northing": "cbv:Comp-northing",
                "latitude": "cbv:Comp-latitude",
                "longitude": "cbv:Comp-longitude",
                "altitude": "cbv:Comp-altitude",
                "geocoordinate": "cbv:Comp-geocoordinate"

@mgh128

  1. I think we agreed, and the examples include, Capitalized versions of the above barewords. Please fix either the examples; or the JSON context and CBV.ttl. @CraigRe what does the CBV doc say?
  2. I have an objection against the last bareword (where the value should be geo: URL). What we discussed, and what SensorDataExample16.jsonld shows, and what WithSensorData/README.md describes is a simpler way:
    "bizStep": "sensor_reporting",
    "readPoint": { "id": "geo:42.698334,23.319941" }

Why do you want the more complex way with geocoordinate? And what would be "type" in that case?

If you agree, please remove geocoordinate from context and from CBV.ttl.

cbv:Comp-geocoordinate  a       cbv:Comp ;
        rdfs:comment      "RFC5870-compliant geographic location URI expressed via the uriValue field"@en ;
        rdfs:isDefinedBy  cbv: ;
        rdfs:label        "geocoordinate"@en ;
        owl:sameAs        <urn:epcglobal:cbv:comp:geocoordinate> ;
        sw:term_status    "stable" .

If you disagree, let's vote and then add a bit more from README into rdfs:comment (use new lines with '"""') and into rdfs:seeAlso. Citing README:

mgh128 commented 2 years ago

Public review draft CBV §7.8.3 shows these enumerations for component lower case as above. Sensor data examples 10, 14, 15 also use lower-case values.

Regarding geocoordinate I think I agree that this could/should be removed because it's not being used to distinguish one component from another in the way that x, y, z or northing vs easting do. I'll therefore submit a review comment asking the group to consider removing geocoordinate from this table.
I'll submit a separate review comment asking the group to consider whether the enumerated values for component should be lower-case, all-caps or only with capitalisation of the initial letter, the latter being consistent with the approach for values of type (e.g. gs1:AbsoluteHumidity , gs1:Temperature ) currently under GMD SMG review.

VladimirAlexiev commented 2 years ago

@mgh128 Good! I pulled and checked, currently ALL jsonld examples use lowercase component:

cd ../JSON-simple-context/
grep component *.jsonld */*.jsonld

So I vote to keep it lowercase.

However:

VladimirAlexiev commented 2 years ago

Checked again:

VladimirAlexiev commented 1 year ago

@dakbhavesh or @RalphTro can you fix this last bullet? Eg https://github.com/gs1/EPCIS/blame/master/JSON-simple-context/WithFullCombinationOfFields/aggregation_event_all_possible_fields.jsonld#L98

RalphTro commented 1 year ago

Dear @VladimirAlexiev , Gladly. Done!

VladimirAlexiev commented 1 year ago

Hmm, the last change I see in https://github.com/gs1/EPCIS/tree/master/JSON-simple-context/WithFullCombinationOfFields is on Apr 19, 2022