Open sgpinkus opened 2 years ago
Thanks - I have noted the typo for Resoruce, together with approximately 80 further typos which are easy to fix. ( Personally I prefer the earlier process in which there was a thorough work group review before community review - but I don't set the timelines ). I think you're probably correct that ReadPointID, BusinessLocationID (but not BusinessStepID) are subclasses of LocationID. SourceDestID can also be a subclass of LocationID but can sometimes by a subclass of OrganizationID (when indicating a source/destination organization in a chain of custody or ownership, rather than a source/destination location). I'll check that this feedback is included in our combined spreadsheet of review comments and acted upon.
Please note that SourceOrDestination is a class with two fields:
That imho is another reason why it cannot be a subtype of an ID.
I don't know how the PDF at https://www.gs1.org/standards/development-work-groups/public-reviews#EPCISCBV_Public-Review-2021 gets built or if these errors have been corrected already, but I noticed a couple: