search

gs1 / EPCIS

Draft files being shared for EPCIS 2.0 development
Other
20 stars 7 forks source link

Replace examples #363

Closed domguinard closed 2 years ago

domguinard commented 2 years ago

Change EPCISQueryDocument examples to https://github.com/gs1/EPCIS/blob/master/JSON/EPCISQueryDocument.jsonld - change the second eventID to a UID

VladimirAlexiev commented 2 years ago

Add to epcis-context-simple.jsonld:

    "EPCISQueryDocument": "epcis:EPCISQueryDocument",
    "epcisHeader": "epcis:epcisHeader",
    "epcisBody": "epcis:epcisBody",
    "queryResults": "epcis:queryResults",
    "subscriptionID": "epcis:subscriptionID",
    "queryName": "epcis:queryName",
    "resultsBody": "epcis:resultsBody",
    "children": {
      "@id": "epcis:children",
      "@container": "@set",
      "@type": "@id"
    }

I found this at the end of epcis-context.jsonld. @domguinard :

domguinard commented 2 years ago

Addressed via PR #368

domguinard commented 2 years ago

Not entirely sure I understand your comment @VladimirAlexiev - this task was only about replacing the example with the latest JSON EPCISQueryDocument example from @mgh128 which I did. Do let me know if I missed something.

VladimirAlexiev commented 2 years ago

@domguinard @mgh128 Since we don't have (and don't need) a semantic model for EPCISQueryDocument, please rename EPCISQueryDocument.jsonld -> EPCISQueryDocument.json . Otherwise Turtle/Makefile will pick it up and try to RDFize it.

mgh128 commented 2 years ago

@VladimirAlexiev - EPCISDocument and EPCISQueryDocument are structurally different and the updated UML class diagram for EPCIS 2.0 now shows both EPCISDocument and EPCISQueryDocument as roots that eventually navigate to an eventList. This was discussed and agreed a few weeks ago on a work group call, so I made the updates to the UML class diagram.

This probably also means that we need to add to the ontology some additional terms including:

epcis:EPCISQueryBody epcis:queryResults epcis:QueryResults epcis:queryName epcis:resultsBody epcis:subscriptionID epcis:QueryResultsBody

We also need to add epcis:masterData and epcis:vocabularyList (and map those in the JSON-LD context resource) - otherwise any JSON master data declared there (even if used by specific sectors) will not be available as RDF triples, since there are otherwise (currently) no RDF predicates that navigate to those attribute:value pairs expressed in JSON within a vocabularyList.