search

gs1 / EPCIS

Draft files being shared for EPCIS 2.0 development
Other
20 stars 7 forks source link

[REST] Clarify min record time #370

Closed jmcanterafonseca-iota closed 2 years ago

jmcanterafonseca-iota commented 2 years ago

Did you not mean to say: it is used to inform about the minimal record time

no, because the maximum of the last batch of records, corresponds to the minimum of the query. but we will review it during our call today to confirm

mgh128 commented 2 years ago

I'm not sure if this is now ready to merge? According to EPCIS v1.2, section 8.2.5.2,

Non-Normative: Explanation: one possible implementation of this requirement is that the EPCIS service maintains a minRecordTime value for each subscription that exists. The minRecordTime for a given subscription is initially set to initialRecordTime, and updated to the current time each time the query is executed for that subscription. Each time the query is executed, the only events considered are those whose recordTime is greater than or equal to minRecordTime for that subscription.

So, José is almost correct in saying that the value of minRecordTime is the maximum of the recordTime values in the last batch of query results for that subscription - though it's really set to the actual execution time of the previous iteration of that standing query (which returned all events with recordTime values between minRecordTime and executionTime).

Dom is correct in stating that this informs about the current value of minRecordTime for that subscription.

So I'd suggest that to align correctly with what is written in we would change:

In the context of an outstanding query subscription, it is used to inform about the maximum record time of the last batch of events delivered to the client.

to

In the context of an standing query subscription, it is used to inform about the value of 'minRecordTime' (the actual execution time of the previous successful iteration of this standing query subscription).

(If the previous iteration failed to deliver results to the client and the server is aware of this temporary delivery error, then it might be appropriate not to update minRecordTime, so that those events can be included with the next execution attempt)

jmcanterafonseca-iota commented 2 years ago

@mgh128 ready to be re-reviewed, thanks!

mgh128 commented 2 years ago

Thanks, @jmcanterafonseca-iota Merged!