sboeckelmann
commented
2 years ago Yes, sorry that was a typo. I meant persistentDisposition of course.
Let’s take a look at all the changes later today in the group call - I can present and walk through all the relevant changes
Am 08.03.2022 um 12:57 schrieb Mark Harrison @.***>:
@mgh128 commented on this pull request.
@sboeckelmann https://github.com/sboeckelmann - thanks for drafting these changes. I'm hesitant to merge this immediately - need to check the extensive changes in the openapi.yaml and EPCglobal-epcis-query-2_0.wsdl more carefully first. The other changes (not hidden by large diffs) look reasonable and you did actually insert persistentDisposition (even though your comment said parentDisposition, which is not a defined property)
— Reply to this email directly, view it on GitHub https://github.com/gs1/EPCIS/pull/397#pullrequestreview-902918047, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE72UTWHMJOPGZZ3GPFY7QDU646CZANCNFSM5P5CQ3HA. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you were mentioned.
jmcanterafonseca-iota
Hi @mgh128, @CraigRe, @domguinard, @jmcanterafonseca-iota and @dakbhavesh,
it has been quite a journey but I this is a good trade-off.
here's a summary of what I've done:
TBD: I am a developer, so it was easier for me to verify be looking at java code. Therefore I have also added a maven pom.xml for java xml bindings and WebServices code generation within new WSDL folder. shall we keep it or remove it? if kept I would suggest to move into WSDL/java
While working on the XSDs I had to struggle with a major lack of support for XML Schema 1.1 within available toolchains. Even xmllint only supports 1.0, same for the java XJC (xml java compiler) and many other "vanilla" command line tools. btw. in java validating against XML Schema Version 1.1 in own code is no issue, but some build toolchains are really causing lots of pain. For xmllint and XJC integration I took a shortcut by creating local copies of the XSD and replacing xsd:dateTimeStamp with xsd:dateTime.
it looks like XMLs haven't been validated against schema for quite some time ;-)
which brings to to my last point, some observations and changes in XSDs and XMLs:
Yes, unfortunately it's another rather huge pull request - looking forward to get your feedback
Cheers, Sven