search

gs1 / EPCIS

Draft files being shared for EPCIS 2.0 development
Other
20 stars 7 forks source link

[Work in progress] Prevent using CBV Web URIs or URNs on bare word elements #420

Closed jmcanterafonseca-iota closed 2 years ago

jmcanterafonseca-iota commented 2 years ago

@mgh128 a PoC on how it would work. Please let me know your feedback and I will implement similar solution for the rest of fields.

mgh128 commented 2 years ago

Hi @jmcanterafonseca-iota Thanks for this - though I'd actually prepared this yesterday evening and had thought I'd already pushed to GitHub but GitHub Desktop (or I) was in a confused state, so it hadn't actually pushed it to the master branch. Please see https://github.com/gs1/EPCIS/pull/421

mgh128 commented 2 years ago

Thanks @jmcanterafonseca-iota - though I'd already prepared this yesterday for all such situations, I think. Please see my updates https://github.com/gs1/EPCIS/commit/a7921388e2a8721aaa2e62842a2e5abede24707b I thought I'd committed these yesterday but GitHub Desktop (or I) was in a confused state and hadn't actually pushed them to the master branch.

jmcanterafonseca-iota commented 2 years ago

cool, then closing this. You used a more maintainable approach so great! @mgh128

mgh128 commented 2 years ago

Thanks, @jmcanterafonseca-iota - sorry about the mix-up. I'd been resolving some code conflicts using GitHub Desktop and hadn't noticed that it was still stuck in another branch for that, rather than back in the master branch.

At least it's done and seems to be working. Hope you didn't spend too long on it.

jmcanterafonseca-iota commented 2 years ago

nope, it was just a quick PoC to test out, so no worries @mgh128