gs1 / EPCIS

Draft files being shared for EPCIS 2.0 development
Other
20 stars 7 forks source link

validate JSON examples periodically #430

Closed VladimirAlexiev closed 2 years ago

VladimirAlexiev commented 2 years ago

(Spit from #277)

How do we know all examples are valid?

I haven't found any problems in the JSON examples or the JSON schema. But I'm always a bit pessimistic, so it would be nice to implement such validation. It's quite possible it'll find some minor deviation somewhere.

@mgh128 @domguinard @jmcanterafonseca-iota @sboeckelmann @shalikasingh @dakbhavesh @CraigRe Any takers?

jmcanterafonseca-iota commented 2 years ago

all JSON Examples are validated through this script, nothing is needed

https://github.com/gs1/EPCIS/blob/master/JSON-Schema/validate-all.sh

On Sun, May 1, 2022 at 4:47 PM Vladimir Alexiev @.***> wrote:

(Spit from #277 https://github.com/gs1/EPCIS/issues/277)

How do we know all examples are valid?

  • Please add a Makefile to validate all JSON examples against the JSON schema.
  • Validation should be rerun whenever the schema or the example changes, or a new one is added.

I haven't found any problems in the JSON examples or the JSON schema. But I'm always a bit pessimistic, so it would be nice to implement such validation. It's quite possible it'll find some minor deviation somewhere.

@mgh128 https://github.com/mgh128 @domguinard https://github.com/domguinard @jmcanterafonseca-iota https://github.com/jmcanterafonseca-iota @sboeckelmann https://github.com/sboeckelmann @shalikasingh https://github.com/shalikasingh @dakbhavesh https://github.com/dakbhavesh @CraigRe https://github.com/CraigRe Any takers?

— Reply to this email directly, view it on GitHub https://github.com/gs1/EPCIS/issues/430, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQEZJLW2UEDPDQ5PGWI5KC3VH2KP5ANCNFSM5UZ7LRRQ . You are receiving this because you were mentioned.Message ID: @.***>

-- IOTA Foundation Pappelallee 78/79 10437 Berlin, Germany

Board of Directors: Dominik Schiener, Navin Ramachandran ID/Foundation No.: 3416/1234/2 (Foundation Register of Berlin)

VladimirAlexiev commented 2 years ago

@jmcanterafonseca-iota great! Do they all pass?

jmcanterafonseca-iota commented 2 years ago

yep!

On Fri, May 6, 2022 at 2:49 PM Vladimir Alexiev @.***> wrote:

@jmcanterafonseca-iota https://github.com/jmcanterafonseca-iota great! Do they all pass?

— Reply to this email directly, view it on GitHub https://github.com/gs1/EPCIS/issues/430#issuecomment-1119581991, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQEZJLQIGGWOMO3KEXMMZ23VIUIOHANCNFSM5UZ7LRRQ . You are receiving this because you were mentioned.Message ID: @.***>

-- IOTA Foundation Pappelallee 78/79 10437 Berlin, Germany

Board of Directors: Dominik Schiener, Navin Ramachandran ID/Foundation No.: 3416/1234/2 (Foundation Register of Berlin)