Open clementh59 opened 2 years ago
we can take advantage of this tweak to update schemas and also incorporate my on hold PR https://github.com/gs1/EPCIS/pull/438
On Thu, Jul 7, 2022 at 3:52 PM Clément @.***> wrote:
According to this commit https://github.com/gs1/EPCIS/commit/9acbc9c66a4209439a8c6576931d41dac5b99a58 and the official documentation, persistentDisposition should only be allowed in ObjectEvent and TransformationEvent.
The problem is that this issue hasn't been fully addressed, and we can still validate an AggregationEvent, for example, with a persistentDisposition.
Moreover, examples have not been updated either. Here is an example https://github.com/gs1/EPCIS/blob/master/JSON/WithFullCombinationOfFields/aggregation_event_all_possible_fields.jsonld#L169 .
Here is an example https://github.com/gs1/EPCIS/blob/master/EPCIS-JSON-Schema.json#L1754 of line that should be removed in the schema.
Here is how it is defined in the standard: [image: Screenshot 2022-07-06 at 17 22 12] https://user-images.githubusercontent.com/37502419/177790033-46266430-2eb0-4819-8f4d-68ef82ca270b.png
— Reply to this email directly, view it on GitHub https://github.com/gs1/EPCIS/issues/440, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQEZJLV4W3LPVJUW3Q2PP7DVS3OH7ANCNFSM525P3BDA . You are receiving this because you are subscribed to this thread.Message ID: @.***>
-- IOTA Foundation Pappelallee 78/79 10437 Berlin, Germany
Board of Directors: Dominik Schiener, Navin Ramachandran ID/Foundation No.: 3416/1234/2 (Foundation Register of Berlin)
According to this commit and the official documentation,
persistentDisposition
should only be allowed inObjectEvent
andTransformationEvent
.The problem is that this issue hasn't been fully addressed by the commit, and we can still validate an
AggregationEvent
, for example, with apersistentDisposition
.Moreover, examples have not been updated either. Here is an example.
Here is an example of line that should be removed in the schema to make it compliant.