GS1-Extension header value format is not matching between document and openapi.yml

[dakbhavesh]

Dear @domguinard / @mgh128,

We observed a slight mismatch in the format of GS1-Extension header values.

GS1-Extension header value format as mentioned in EPCIS 2.0 specification (Section 12.3 Pg.no. 180 Section 12.7.4 Pg.no. 192-193): “example-epc-ext”:”http://example.com/epcis/”

GS1-Extension header value format in openapi.yml: example-epc-ext=http://org1.example.com/epcis/, example-epc-ext2=http://vendor.example.com/epcis/

If you agree, then we should update the openapi.yml to match the format as per specification. Let us know so that we can raise a PR.

FYI: @sboeckelmann

[jmcanterafonseca-iota]

The spec is correct, the document is not

On Thu, Jul 28, 2022 at 8:46 AM Bhavesh Shah @.***> wrote:

Dear @domguinard https://github.com/domguinard / @mgh128 https://github.com/mgh128,

We observed a slight mismatch in the format of GS1-Extension header values.

GS1-Extension header value format as mentioned in EPCIS 2.0 specification (Section 12.3 Pg.no. 180 Section 12.7.4 Pg.no. 192-193): “example-epc-ext”:”http://example.com/epcis/”

GS1-Extension header value format in openapi.yml: example-epc-ext= http://org1.example.com/epcis/, example-epc-ext2= http://vendor.example.com/epcis/

If you agree, then we should update the openapi.yml to match the format as per specification. Let us know so that we can raise a PR.

FYI: @sboeckelmann https://github.com/sboeckelmann

— Reply to this email directly, view it on GitHub https://github.com/gs1/EPCIS/issues/441, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQEZJLSDIM4J44ESXWUYRRDVWIUCTANCNFSM544CX3BA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- IOTA Foundation Pappelallee 78/79 10437 Berlin, Germany

Board of Directors: Dominik Schiener, Navin Ramachandran ID/Foundation No.: 3416/1234/2 (Foundation Register of Berlin)

[domguinard]

Thanks for flagging @dakbhavesh - I agree with @jmcanterafonseca-iota the OpenAPI spec is correct as the extensions should look like:

GS1-Extensions: example-epc-ext=http://org1.example.com/epcis/, example-epc-ext2=http://vendor.example.com/epcis/ 

Do you agree @dakbhavesh ?

[CraigRe]

Thanks @dakbhavesh , @jmcanterafonseca-iota and @domguinard; we'll also add this one to the running list of planned fixes for the next release of EPCIS.

[dakbhavesh]

Thanks for flagging @dakbhavesh - I agree with @jmcanterafonseca-iota the OpenAPI spec is correct as the extensions should look like:

GS1-Extensions: example-epc-ext=http://org1.example.com/epcis/, example-epc-ext2=http://vendor.example.com/epcis/ 

Do you agree @dakbhavesh ?

I agree @domguinard .