gs1 / GS1DL-resolver-testsuite

A test suite against which a resolver's conformance with the GS1 Digital Link spec can be assessed
Apache License 2.0
6 stars 1 forks source link

Uncompressed URI not found in response link header #14

Open vanceMM0601 opened 3 years ago

vanceMM0601 commented 3 years ago

When i run the GS1 Test Suite with example https://resolver-dv1.gs1.org/01/09506000134352 , i get an error with the following test : If handling a compressed request URI, it SHALL expose the uncompressed URI in the Link response header with a rel value of owl:sameAs. Even though the link header is present and a value of owl:sameAs is set. image

philarcher commented 3 years ago

Ooh, thanks @vanceMM0601 - apologies that it has taken me a month to see your message. I'll look into this and get it fixed.

philarcher commented 3 years ago

I've found out why this happens and, more importantly, why @nicklansley says it doesn't!

It's because the sameAs link, i.e. the uncompressed URI always uses id.gs1.org whatever the domain of the input URI. So we get a red light on resolver-dv1.gs1.org but a green light on id.gs1.org.

So, one for the backlog, Nick. The uncompressed URI in the owl:sameAs link must be on the same domain as the input URI, not the canonical form (there's no guarantee that different resolvers point to the same set of resources and so "resolver foo" may well point somewhere other than wherever id.gs1.org points)