search

gs1 / GS1_DigitalLink_Resolver_CE

The GS1 DigitalLink Resolver Community Edition
Apache License 2.0
42 stars 26 forks source link

@rel values should be CURIEs #4

Closed philarcher closed 4 years ago

philarcher commented 5 years ago

The values of the @rel attribute in links returned by the resolver as presented as unqualified strings that are all lower case. They should be CURIEs (compact URIs) of the form gs1:pip, gs1:relatedVideo etc.

/cc @mgh128

philarcher commented 4 years ago

By the way, under the current situation, links such as this: https://id.gs1.org/01/9506000134352?linkType=gs1:hasRetailers are not being processed correctly because of the (correct) inclusion of gs1: (gs1: expands to https://gs1.org/voc so that this: https://id.gs1.org/01/9506000134352?linkType=https://gs1.org/voc/hasRetailers should also work (i.e. redirect to https://dalgiardino.com/where-to-buy/)

philarcher commented 4 years ago

Thanks Nick, that appears to be working properly now. We'll keep testing for the time being but first impressions - this looks right. I note that if the gs1: prefix is not included, the link type still works. That is: https://id.gs1.org/01/9506000134352?linkType=hasRetailers AND https://id.gs1.org/01/9506000134352?linkType=gs1:hasRetailers both work. That's an implementation choice for id.gs1.org, not part of the standard - and probably a practical one for now. We'll have to assess whether to continue that support in future.

philarcher commented 4 years ago

We can mark this is closed for now (we can always re-open the issue if it resurfaces).