search

gs1 / GS1_DigitalLink_Resolver_CE

The GS1 DigitalLink Resolver Community Edition
Apache License 2.0
41 stars 26 forks source link

Update web_namespace.py #98

Closed bishwaranjans closed 2 months ago

bishwaranjans commented 3 months ago

Fixed the bug for casting error with null and string

nicklansley commented 3 months ago

Thanks @bishwaranjans

Can you just check the logic for the decision made? Currently it is:

                if not qualifier_path:
                    return _process_response(doc_id, identifiers, qualifier_path)
                else:
                    return _process_response(doc_id, identifiers)

With the change you made, I think it should be this. Can you check your end?

                if not qualifier_path:
                    return _process_response(doc_id, identifiers)
                else:
                    return _process_response(doc_id, identifiers, qualifier_path)

... which we could simplify this to:

return _process_response(doc_id, identifiers, qualifier_path or None)
nicklansley commented 2 months ago 
return _process_response(doc_id, identifiers, qualifier_path or None)

This is now implemented