search

gsainfoteam / groups-be

group의 권한을 확인하는 프로젝트입니다.
https://api.groups.gistory.me/
GNU Affero General Public License v3.0
1 stars 1 forks source link

feat: return Group in group create controller #68

Closed dawnfire05 closed 1 month ago

dawnfire05 commented 1 month ago

close #67

Summary by CodeRabbit

coderabbitai[bot] commented 1 month ago
📝 Walkthrough
📝 Walkthrough ## Walkthrough 이 변경 사항은 `GroupCreateResDto` 클래스의 도입과 함께, `GroupController`, `GroupService`, 및 `GroupRepository` 클래스의 `createGroup` 메서드의 반환 유형을 `Promise`에서 `Promise`로 수정하는 것을 포함합니다. 이로 인해 각 메서드는 이제 생성된 그룹에 대한 DTO 객체를 반환하며, 클라이언트에 더 많은 정보를 제공할 수 있게 됩니다. ## Changes | 파일 | 변경 요약 | |---------------------------------------------------|--------------------------------------------------------------------------------------------------------------------------------------------| | `src/group/dto/res/groupCreateRes.dto.ts` | `GroupCreateResDto` 클래스 추가, `Group` 인터페이스 구현. | | `src/group/group.controller.ts`, `src/group/group.service.ts`, `src/group/group.repository.ts` | `createGroup` 메서드의 반환 유형을 `Promise`에서 `Promise`로 변경하고, DTO를 반환하도록 구현 수정. | ## Assessment against linked issues | Objective | Addressed | Explanation | |---------------------------------------------|-----------|------------------------------------| | 그룹을 생성한 후 그룹을 리턴하지 않습니다. (이슈 #67) | ✅ | | ## Possibly related PRs - #58: `GroupController`, `GroupService`, 및 `GroupRepository`의 `createGroup` 메서드 반환 유형을 `Promise`로 변경하는 내용이 포함되어 있습니다. - #66: `GroupService`와 `GroupController`를 수정하여 그룹 생성 전에 그룹 존재 여부를 확인하는 로직이 추가되었습니다. ## Suggested labels `enhancement` ## Suggested reviewers - siwonpada ## Poem > 🐰 새로운 그룹이 태어났네, > 반환된 그룹이 기쁘게 웃네. > 코드가 변해 더 나은 길로, > 함께 달려가자, 우리 모두! > 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
siwonpada commented 1 month ago

Prisma에서 만들어준 Group으로 리턴을 하면, 아마 swagger에 문서화가 안될 겁니다. 따라서 response를 위한 dto를 만들어야할 것 같습니다.

dawnfire05 commented 1 month ago

Prisma에서 만들어준 Group으로 리턴을 하면, 아마 swagger에 문서화가 안될 겁니다. 따라서 response를 위한 dto를 만들어야할 것 같습니다.

알겠습니다.