search

gsainfoteam / groups-be

group의 권한을 확인하는 프로젝트입니다.
https://api.groups.gistory.me/
GNU Affero General Public License v3.0
1 stars 1 forks source link

modify: add invitation code expiration duration #71

Closed GanghyeonSeo closed 1 month ago

GanghyeonSeo commented 1 month ago

Summary by CodeRabbit

coderabbitai[bot] commented 1 month ago
📝 Walkthrough
📝 Walkthrough ## Walkthrough 이번 변경 사항은 초대 만료 기간을 캡슐화하기 위한 새로운 데이터 전송 객체(DTO) 클래스 `InvitationExpDto`의 추가와 `PresidentResDto` 클래스의 가시성 변경을 포함합니다. 또한, 초대 정보에 대한 DTO인 `InvitationInfoResDto`가 도입되었으며, `GroupController`와 `GroupService` 클래스에 새로운 메서드와 엔드포인트가 추가되었습니다. 이로 인해 초대 코드의 만료 시간을 설정하고, 초대된 그룹의 이름과 회장 이메일을 조회할 수 있는 기능이 구현되었습니다. ## Changes | 파일 경로 | 변경 요약 | |-------------------------------------|------------------------------------------------------------------------------------------| | `src/group/dto/req/invitationExp.dto.ts` | - 클래스 추가: `export class InvitationExpDto`
- 속성 추가: `duration: number` | | `src/group/dto/res/ExpandedGroupRes.dto.ts` | - 클래스 가시성 변경: `export class PresidentResDto` | | `src/group/dto/res/invitationInfoRes.dto.ts` | - 클래스 추가: `export class InvitationInfoResDto`
- 메서드 추가: `get presidentEmail()`
- 속성 추가: `name` | | `src/group/group.controller.ts` | - 메서드 추가: `async getInvitationInfo(...)`
- 메서드 시그니처 업데이트: `createInviteCode(...)` | | `src/group/group.service.ts` | - 메서드 시그니처 업데이트: `createInviteCode(...)`
- 메서드 추가: `async getInvitationInfo(...)` | ## Possibly related PRs - **#66**: `CheckGroupExistenceByNameDto` 클래스의 도입은 `InvitationExpDto` 클래스 추가와 유사하며, 두 변경 사항 모두 특정 데이터 구조를 캡슐화하기 위한 새로운 DTO를 생성하는 것입니다. - **#68**: `GroupController`와 `GroupService`의 변경 사항은 새로운 DTO인 `GroupCreateResDto`를 도입하며, 이는 `InvitationExpDto` 추가와 유사한 방식으로 메서드 시그니처를 수정합니다. ## Suggested labels `enhancement` ## Suggested reviewers - siwonpada ## Poem > 🐰 초대장과 함께, > 만료 시간 정해, > 회장님 이메일, > 그룹 이름도 찾아, > 새로운 길 열리네, > 기쁨 가득하네! 🌼

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.