search

gsainfoteam / groups-be

group의 권한을 확인하는 프로젝트입니다.
https://api.groups.gistory.me/
GNU Affero General Public License v3.0
1 stars 1 forks source link

[BUG] group profile url is not fully provided, it has just s3 key #75

Closed siwonpada closed 1 month ago

siwonpada commented 1 month ago

Fixes #73

Summary by CodeRabbit

coderabbitai[bot] commented 1 month ago
📝 Walkthrough ## Walkthrough 이 풀 리퀘스트는 여러 DTO 클래스와 서비스, 컨트롤러의 변경 사항을 포함하고 있습니다. 주요 변경 사항은 `s3Url` 속성과 이를 기반으로 한 `profileImageUrl` 계산 속성을 추가하는 것입니다. 또한, `ConfigService`를 주입하여 AWS S3의 URL을 설정하고, 여러 메서드의 반환 타입을 새로운 DTO로 업데이트했습니다. 불필요한 import를 제거하고, 일부 메서드의 반환 타입을 더 직접적인 객체로 변경했습니다. ## Changes | 파일 경로 | 변경 요약 | |-----------------------------------|------------------------------------------------------------------------------------------| | src/external/dto/res/externalInfoRes.dto.ts | `GroupWithRoleResDto`에 `profileImageUrl` 및 `s3Url` 추가, 생성자 수정 | | src/external/external.service.ts | `ExternalService`에 `ConfigService` 주입, `getExternalInfo` 메서드 수정 | | src/group/dto/res/ExpandedGroupRes.dto.ts | `ExpandedGroupResDto`에 `profileImageUrl` 및 `s3Url` 추가, 생성자 수정 | | src/group/dto/res/groupCreateRes.dto.ts | `GroupCreateResDto`에 `profileImageUrl` 및 `s3Url` 추가, 생성자 추가 | | src/group/dto/res/groupRes.dto.ts | `GroupResDto`에 `profileImageUrl` 및 `s3Url` 추가, 생성자 수정 | | src/group/dto/res/invitationInfoRes.dto.ts | `InvitationInfoResDto`에 `profileImageUrl` 및 `s3Url` 추가, 생성자 수정 | | src/group/group.controller.ts | `GroupResDto` import 제거, `getGroupList` 및 `getMemberInGroup` 메서드 간소화 | | src/group/group.repository.ts | `createGroup` 메서드 반환 타입을 `Promise`로 변경, `GroupCreateResDto` import 제거 | | src/group/group.service.ts | `ConfigService` 주입, 여러 메서드 반환 타입을 새로운 DTO로 변경 | ## Assessment against linked issues | Objective | Addressed | Explanation | |-----------------------------------------------------|-----------|----------------------------------| | 그룹 프로필 URL이 완전히 제공되지 않는 버그 수정 (#73) | ✅ | | ## Possibly related PRs - **#68**: 이 PR은 `src/group/dto/res/groupCreateRes.dto.ts`의 `GroupCreateResDto` 클래스를 수정하여 `s3Url` 속성과 계산된 `profileImageUrl`을 포함하는 변경 사항이 있어 관련이 있습니다. ## Suggested reviewers - GanghyeonSeo > 🐰 변화의 기쁨을 노래해, > 프로필 이미지 URL이 생겼네! > S3의 비밀을 담아내고, > 그룹의 모습 더욱 빛나리. > 모두 함께 즐거운 날, > 변화는 언제나 환영해! 🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.