search

gsainfoteam / ziggle-be

Ziggle의 백엔드 리포지토리 입니다.
https://api.ziggle.gistory.me
GNU Affero General Public License v3.0
5 stars 1 forks source link

hotfix: modify classvalidator dec #99

Closed siwonpada closed 1 month ago

siwonpada commented 1 month ago

Summary by CodeRabbit

coderabbitai[bot] commented 1 month ago
Walkthrough ## Walkthrough 이번 변경 사항은 `src/ai/dto/req/translate.dto.ts` 파일에 있는 `TranslateDto` 클래스의 `targetLang` 속성에 적용된 유효성 검사 데코레이터의 수정에 관한 것입니다. 이전의 `@IsISO31661Alpha2()` 데코레이터는 `targetLang`이 유효한 ISO 3166-1 알파-2 국가 코드여야 한다고 강제했으나, 이제 `@IsLocale()`로 변경되어 `targetLang`이 유효한 로케일 문자열인지 검증합니다. 전체 클래스 구조는 변경되지 않았습니다. ## Changes | 파일 경로 | 변경 요약 | |-----------------------------------|--------------------------------------------------------------------------------------------| | `src/ai/dto/req/translate.dto.ts` | `TranslateDto` 클래스의 `targetLang` 속성의 유효성 검사 데코레이터가 `@IsISO31661Alpha2()`에서 `@IsLocale()`로 변경됨. | ## Poem > 🐇 > 언어의 숲을 뛰어다니며, > 새로운 로케일을 찾았네. > 코드의 변화, 기쁜 소식, > 더 넓은 세상으로 나아가네. > Rabbit's joy, in every string, > 함께 춤추며 노래하리! 🌍✨
Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between 6d500d4b169aafd88723bc936159942cea86c071 and f12db7b5f6e34c0535d71e60bb8e9b8cfa08acea.
Files selected for processing (1) * src/ai/dto/req/translate.dto.ts (2 hunks)
Additional comments not posted (1)
src/ai/dto/req/translate.dto.ts (1)
`16-16`: **유효성 검사 변경을 승인합니다. 하지만 비즈니스 로직에 미치는 영향을 확인하세요.** `targetLang` 속성의 유효성 검사 데코레이터를 `@IsISO31661Alpha2()`에서 `@IsLocale()`로 변경하는 것은 타당해 보입니다. 이를 통해 `targetLang`에 대해 보다 광범위한 언어 및 지역 식별자를 허용할 수 있습니다. 그러나 이 변경이 `targetLang` 속성이 유효한 ISO 3166-1 alpha-2 국가 코드여야 한다는 비즈니스 로직에 영향을 미칠 수 있습니다. 변경의 영향을 철저히 검토하고 필요한 경우 관련 비즈니스 로직을 업데이트하세요. 다음 스크립트를 실행하여 `targetLang` 속성의 사용을 확인하세요:
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: -- `I pushed a fix in commit , please review it.` -- `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: -- `@coderabbitai generate unit testing code for this file.` -- `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: -- `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` -- `@coderabbitai read src/utils.ts and generate unit testing code.` -- `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` -- `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.